chore: run skipped tests

Author: ascorbic

.github/workflows/e2e-next.yml

@@ -54,6 +54,7 @@ jobs:
           CHUNKS: ${{ needs.setup.outputs['test-chunks'] }}
           NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_BOT_AUTH_TOKEN }}
           NETLIFY_SITE_ID: 1d5a5c76-d445-4ae5-b694-b0d3f2e2c395
+          RUN_ALL_TESTS: true
       - uses: phoenix-actions/test-reporting@v10
         if: ${{ always() }}
         name: Report Test Results

test/e2e/modified-tests/edge-compiler-can-import-blob-assets/index.test.ts

@@ -6,6 +6,8 @@ import { promises as fs } from 'fs'
 import { readJson } from 'fs-extra'
 import type { MiddlewareManifest } from 'next/build/webpack/plugins/middleware-plugin'
 
+const mostlySkip = process.env.RUN_ALL_TESTS === 'true' ? it : it.skip
+
 describe('Edge Compiler can import asset assets', () => {
   let next: NextInstance
 
@@ -22,14 +24,14 @@ describe('Edge Compiler can import asset assets', () => {
   })
   afterAll(() => next.destroy())
   // NTL Fail
-  it.skip('allows to fetch a remote URL', async () => {
+  mostlySkip('allows to fetch a remote URL', async () => {
     const response = await fetchViaHTTP(next.url, '/api/edge', {
       handler: 'remote-full',
     })
     expect(await response.text()).toContain('Example Domain')
   })
   // NTL Fail
-  it.skip('allows to fetch a remote URL with a path and basename', async () => {
+  mostlySkip('allows to fetch a remote URL with a path and basename', async () => {
     const response = await fetchViaHTTP(
       next.url,
       '/api/edge',
@@ -50,7 +52,7 @@ describe('Edge Compiler can import asset assets', () => {
     expect(html).toContain('Hello, from text-file.txt!')
   })
   // NTL Fail
-  it.skip('allows to fetch image assets', async () => {
+  mostlySkip('allows to fetch image assets', async () => {
     const response = await fetchViaHTTP(next.url, '/api/edge', {
       handler: 'image-file',
     })

test/e2e/modified-tests/middleware-general/test/index.test.ts

@@ -6,6 +6,7 @@ import webdriver from 'next-webdriver'
 import { NextInstance } from 'test/lib/next-modes/base'
 import { check, fetchViaHTTP, waitFor } from 'next-test-utils'
 import { createNext, FileRef } from 'e2e-utils'
+const mostlySkip = process.env.RUN_ALL_TESTS === 'true' ? it : it.skip
 
 const urlsError = 'Please use only absolute URLs'
 
@@ -140,7 +141,7 @@ describe('Middleware Runtime', () => {
       })
     }
     // NTL Fail
-    it.skip('passes search params with rewrites', async () => {
+    mostlySkip('passes search params with rewrites', async () => {
       const response = await fetchViaHTTP(next.url, `/api/edge-search-params`, {
         a: 'b',
       })
@@ -258,7 +259,7 @@ describe('Middleware Runtime', () => {
       expect(await browser.elementByCss('#as-path').text()).toBe('/rewrite-to-config-rewrite')
     })
     // NTL Fail
-    it.skip('should have correct route params for rewrite from config dynamic route', async () => {
+    mostlySkip('should have correct route params for rewrite from config dynamic route', async () => {
       const browser = await webdriver(next.url, '/')
       await browser.eval('window.beforeNav = 1')
       await browser.eval('window.next.router.push("/rewrite-3")')
@@ -275,7 +276,7 @@ describe('Middleware Runtime', () => {
       expect(await browser.elementByCss('#as-path').text()).toBe('/rewrite-3')
     })
     // NTL Fail
-    it.skip('should have correct route params for rewrite from config non-dynamic route', async () => {
+    mostlySkip('should have correct route params for rewrite from config non-dynamic route', async () => {
       const browser = await webdriver(next.url, '/')
       await browser.eval('window.beforeNav = 1')
       await browser.eval('window.next.router.push("/rewrite-1")')
@@ -287,7 +288,7 @@ describe('Middleware Runtime', () => {
       })
     })
     // NTL Fail
-    it.skip('should redirect the same for direct visit and client-transition', async () => {
+    mostlySkip('should redirect the same for direct visit and client-transition', async () => {
       const res = await fetchViaHTTP(next.url, `/redirect-1`, undefined, {
         redirect: 'manual',
       })
@@ -302,7 +303,7 @@ describe('Middleware Runtime', () => {
       }, 'success')
     })
     // NTL Fail
-    it.skip('should rewrite the same for direct visit and client-transition', async () => {
+    mostlySkip('should rewrite the same for direct visit and client-transition', async () => {
       const res = await fetchViaHTTP(next.url, `/rewrite-1`)
       expect(res.status).toBe(200)
       expect(await res.text()).toContain('Hello World')
@@ -317,7 +318,7 @@ describe('Middleware Runtime', () => {
       expect(await browser.eval('window.beforeNav')).toBe(1)
     })
     // NTL Fail
-    it.skip('should rewrite correctly for non-SSG/SSP page', async () => {
+    mostlySkip('should rewrite correctly for non-SSG/SSP page', async () => {
       const res = await fetchViaHTTP(next.url, `/rewrite-2`)
       expect(res.status).toBe(200)
       expect(await res.text()).toContain('AboutA')
@@ -351,7 +352,7 @@ describe('Middleware Runtime', () => {
       })
     }
     // NTL Fail
-    it.skip('should contain process polyfill', async () => {
+    mostlySkip('should contain process polyfill', async () => {
       const res = await fetchViaHTTP(next.url, `/global`)
       expect(readMiddlewareJSON(res)).toEqual({
         process: {
@@ -389,7 +390,7 @@ describe('Middleware Runtime', () => {
       })
     }
     //  Fail
-    it.skip(`should allow to abort a fetch request`, async () => {
+    mostlySkip(`should allow to abort a fetch request`, async () => {
       const response = await fetchViaHTTP(next.url, '/abort-controller')
       const payload = readMiddlewareJSON(response)
       expect('error' in payload).toBe(true)

test/e2e/modified-tests/middleware-rewrites/test/index.test.ts

@@ -7,6 +7,7 @@ import { NextInstance } from 'test/lib/next-modes/base'
 import { check, fetchViaHTTP } from 'next-test-utils'
 import { createNext, FileRef } from 'e2e-utils'
 import escapeStringRegexp from 'escape-string-regexp'
+const mostlySkip = process.env.RUN_ALL_TESTS === 'true' ? it : it.skip
 
 describe('Middleware Rewrite', () => {
   let next: NextInstance
@@ -56,7 +57,7 @@ describe('Middleware Rewrite', () => {
     })
 
     // NTL Fail
-    it.skip('should have props for afterFiles rewrite to SSG page', async () => {
+    mostlySkip('should have props for afterFiles rewrite to SSG page', async () => {
       let browser = await webdriver(next.url, '/')
       await browser.eval(`next.router.push("/afterfiles-rewrite-ssg")`)
 
@@ -78,7 +79,7 @@ describe('Middleware Rewrite', () => {
     })
 
     // TODO: middleware effect headers aren't available here
-    it.skip('includes the locale in rewrites by default', async () => {
+    mostlySkip('includes the locale in rewrites by default', async () => {
       const res = await fetchViaHTTP(next.url, `/rewrite-me-to-about`)
       expect(res.headers.get('x-middleware-rewrite')?.endsWith('/en/about')).toEqual(true)
     })
@@ -189,7 +190,7 @@ describe('Middleware Rewrite', () => {
       await check(() => browser.eval('document.documentElement.innerHTML'), /Example Domain/)
     })
     // NTL Fail
-    it.skip('should rewrite to fallback: true page successfully', async () => {
+    mostlySkip('should rewrite to fallback: true page successfully', async () => {
       const randomSlug = `another-${Date.now()}`
       const res2 = await fetchViaHTTP(next.url, `/to-blog/${randomSlug}`)
       expect(res2.status).toBe(200)

test/e2e/modified-tests/skip-trailing-slash-redirect/index.test.ts

@@ -3,6 +3,7 @@ import { NextInstance } from 'test/lib/next-modes/base'
 import { check, fetchViaHTTP } from 'next-test-utils'
 import { join } from 'path'
 import webdriver from 'next-webdriver'
+const mostlySkip = process.env.RUN_ALL_TESTS === 'true' ? it : it.skip
 
 describe('skip-trailing-slash-redirect', () => {
   let next: NextInstance
@@ -47,15 +48,15 @@ describe('skip-trailing-slash-redirect', () => {
     expect(await res.text()).toBe('hello from middleware')
   })
   // NTL Skip
-  it.skip('should merge cookies from middleware and API routes correctly', async () => {
+  mostlySkip('should merge cookies from middleware and API routes correctly', async () => {
     const res = await fetchViaHTTP(next.url, '/api/test-cookie', undefined, {
       redirect: 'manual',
     })
     expect(res.status).toBe(200)
     expect(res.headers.get('set-cookie')).toEqual('from-middleware=1; Path=/, hello=From API')
   })
   // NTL Skip
-  it.skip('should merge cookies from middleware and edge API routes correctly', async () => {
+  mostlySkip('should merge cookies from middleware and edge API routes correctly', async () => {
     const res = await fetchViaHTTP(next.url, '/api/test-cookie-edge', undefined, {
       redirect: 'manual',
     })
@@ -117,7 +118,7 @@ describe('skip-trailing-slash-redirect', () => {
     expect(await res.text()).toContain('another page')
   })
   // NTL Skip
-  it.skip('should not apply trailing slash redirect (with slash)', async () => {
+  mostlySkip('should not apply trailing slash redirect (with slash)', async () => {
     const res = await fetchViaHTTP(next.url, '/another/', undefined, {
       redirect: 'manual',
     })

test/e2e/modified-tests/streaming-ssr/index.test.ts

@@ -7,6 +7,7 @@ const react18Deps = {
   react: '^18.0.0',
   'react-dom': '^18.0.0',
 }
+const mostlySkip = process.env.RUN_ALL_TESTS === 'true' ? it : it.skip
 
 const isNextProd = !(global as any).isNextDev && !(global as any).isNextDeploy
 
@@ -30,7 +31,7 @@ describe('react 18 streaming SSR with custom next configs', () => {
   })
   afterAll(() => next.destroy())
   //  NTL Skip
-  it.skip('should match more specific route along with dynamic routes', async () => {
+  mostlySkip('should match more specific route along with dynamic routes', async () => {
     const res1 = await fetchViaHTTP(next.url, '/api/user/login')
     const res2 = await fetchViaHTTP(next.url, '/api/user/any')
     expect(await res1.text()).toBe('login')
@@ -42,7 +43,7 @@ describe('react 18 streaming SSR with custom next configs', () => {
     expect(html).toContain('color:blue')
   })
   // NTL Skip
-  it.skip('should redirect paths without trailing-slash and render when slash is appended', async () => {
+  mostlySkip('should redirect paths without trailing-slash and render when slash is appended', async () => {
     const page = '/hello'
     const redirectRes = await fetchViaHTTP(next.url, page, {}, { redirect: 'manual' })
     const res = await fetchViaHTTP(next.url, page + '/')