fixup! chore: add some validation to bundling to ensure we don't produce duplicate/inling of regional-blob-store module in unexptected built modules

Author: pieh

tools/build.js

@@ -132,13 +132,13 @@ await Promise.all([
 async function ensureNoRegionalBlobsModuleDuplicates() {
   const REGIONAL_BLOB_STORE_CONTENT_TO_FIND = 'fetchBeforeNextPatchedIt'
 
-  const filesToTest = await glob(join(OUT_DIR, '**/*.{js,cjs}'))
+  const filesToTest = await glob(`${OUT_DIR}/**/*.{js,cjs}`)
   const unexpectedModulesContainingFetchBeforeNextPatchedIt = []
   let foundInExpectedModule = false
   for (const fileToTest of filesToTest) {
     const content = await readFile(fileToTest, 'utf-8')
     if (content.includes(REGIONAL_BLOB_STORE_CONTENT_TO_FIND)) {
-      if (fileToTest.endsWith(join('run', 'regional-blob-store.cjs'))) {
+      if (fileToTest.endsWith('run/regional-blob-store.cjs')) {
         foundInExpectedModule = true
       } else {
         unexpectedModulesContainingFetchBeforeNextPatchedIt.push(fileToTest)
@@ -147,12 +147,12 @@ async function ensureNoRegionalBlobsModuleDuplicates() {
   }
   if (!foundInExpectedModule) {
     throw new Error(
-      'Expected to find fetchBeforeNextPatchedIt in run/regional-blob-store.cjs, but it was not found. This might indicate setup change that require bundling validation to be adjusted.',
+      'Expected to find "fetchBeforeNextPatchedIt" variable in "run/regional-blob-store.cjs", but it was not found. This might indicate setup change that require bundling validation in "tools/build.js" to be adjusted.',
     )
   }
   if (unexpectedModulesContainingFetchBeforeNextPatchedIt.length !== 0) {
     throw new Error(
-      `Bundling produced unexpected duplicates of 'regional-blob-store' module in following built modules:\n${unexpectedModulesContainingFetchBeforeNextPatchedIt.map((filePath) => ` - ${filePath}`).join('\n')}`,
+      `Bundling produced unexpected duplicates of "regional-blob-store" module in following built modules:\n${unexpectedModulesContainingFetchBeforeNextPatchedIt.map((filePath) => ` - ${filePath}`).join('\n')}`,
     )
   }
 }