Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 94e28fc

Browse files
committedOct 16, 2024··
chore(deps): use netlify-cli dev dep where possible
Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484.
1 parent 01651dc commit 94e28fc

File tree

4 files changed

+39776
-12454
lines changed

4 files changed

+39776
-12454
lines changed
 

‎.github/workflows/run-tests.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,7 @@ jobs:
7272
env:
7373
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
7474
run: |
75-
# TODO(serhalp) Unpin version once
76-
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
77-
npm i -g netlify-cli@17.26.0
78-
netlify login
75+
npx netlify login
7976
- name: Get installed Playwright version
8077
id: playwright-version
8178
run: echo "version=$(npm view @playwright/test version)" >> $GITHUB_OUTPUT
@@ -208,10 +205,7 @@ jobs:
208205
env:
209206
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
210207
run: |
211-
# TODO(serhalp) Unpin version once
212-
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
213-
npm i -g netlify-cli@17.26.0
214-
netlify login
208+
npx netlify login
215209
- name: Resolve Next.js version
216210
id: resolve-next-version
217211
shell: bash

‎.github/workflows/test-e2e.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,8 @@ jobs:
180180
run: npm run build
181181
working-directory: ${{ env.runtime-path }}
182182

183+
# TODO(serhalp) Use the netlify-cli dev dep? It's a bit trickier here because we're running in
184+
# the next.js directory, not the next-runtime directory. See https://github.com/netlify/next-runtime/pull/2484.
183185
- name: add netlify cli
184186
run: npm install -g netlify-cli
185187

‎package-lock.json

Lines changed: 39771 additions & 12446 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
"memfs": "^4.9.2",
8080
"mock-require": "^3.0.3",
8181
"msw": "^2.0.7",
82+
"netlify-cli": "^17.37.0",
8283
"next": "^15.0.0-canary.28",
8384
"os": "^0.1.2",
8485
"outdent": "^0.8.0",

0 commit comments

Comments
 (0)
Please sign in to comment.