refactor: include sharp module when ipx is disabled

don't add ipx function to netlifyConfig if ipx is disabled

Author: ericapisani

packages/runtime/src/helpers/config.ts

@@ -8,6 +8,7 @@ import slash from 'slash'
 import { HANDLER_FUNCTION_NAME, ODB_FUNCTION_NAME } from '../constants'
 
 import type { RoutesManifest } from './types'
+import { isEnvSet } from './utils'
 
 const ROUTES_MANIFEST_FILE = 'routes-manifest.json'
 
@@ -77,16 +78,20 @@ const resolveModuleRoot = (moduleName) => {
   }
 }
 
-const DEFAULT_EXCLUDED_MODULES = ['sharp', 'electron']
+const configureDefaultExcludedModules = () => (isEnvSet('DISABLE_IPX') ? ['electron'] : ['sharp', 'electron'])
+
+const DEFAULT_EXCLUDED_MODULES = configureDefaultExcludedModules()
 
 export const configureHandlerFunctions = async ({ netlifyConfig, publish, ignore = [] }) => {
   const config = await getRequiredServerFiles(publish)
   const files = config.files || []
   const cssFilesToInclude = files.filter((f) => f.startsWith(`${publish}/static/css/`))
 
   /* eslint-disable no-underscore-dangle */
-  netlifyConfig.functions._ipx ||= {}
-  netlifyConfig.functions._ipx.node_bundler = 'nft'
+  if (!isEnvSet('DISABLE_IPX')) {
+    netlifyConfig.functions._ipx ||= {}
+    netlifyConfig.functions._ipx.node_bundler = 'nft'
+  }
 
   /* eslint-enable no-underscore-dangle */
   ;[HANDLER_FUNCTION_NAME, ODB_FUNCTION_NAME].forEach((functionName) => {

packages/runtime/src/helpers/functions.ts

@@ -7,6 +7,7 @@ import { join, relative, resolve } from 'pathe'
 import { HANDLER_FUNCTION_NAME, ODB_FUNCTION_NAME, IMAGE_FUNCTION_NAME, DEFAULT_FUNCTIONS_SRC } from '../constants'
 import { getHandler } from '../templates/getHandler'
 import { getPageResolver } from '../templates/getPageResolver'
+
 import { isEnvSet } from './utils'
 
 export const generateFunctions = async (
@@ -70,8 +71,7 @@ export const setupImageFunction = async ({
   remotePatterns: RemotePattern[]
   responseHeaders?: Record<string, string>
 }): Promise<void> => {
-  
-  if(!isEnvSet('DISABLE_IPX')) {
+  if (!isEnvSet('DISABLE_IPX')) {
     const functionsPath = INTERNAL_FUNCTIONS_SRC || FUNCTIONS_SRC
     const functionName = `${IMAGE_FUNCTION_NAME}.js`
     const functionDirectory = join(functionsPath, IMAGE_FUNCTION_NAME)
@@ -83,7 +83,7 @@ export const setupImageFunction = async ({
       remotePatterns,
       responseHeaders,
     })
-    
+
     await copyFile(join(__dirname, '..', '..', 'lib', 'templates', 'ipx.js'), join(functionDirectory, functionName))
 
     const imagePath = imageconfig.path || '/_next/image'
@@ -96,12 +96,12 @@ export const setupImageFunction = async ({
       to: `${basePath}/${IMAGE_FUNCTION_NAME}/w_:width,q_:quality/:url`,
       status: 301,
     })
-  
+
     netlifyConfig.redirects.push({
       from: `${basePath}/${IMAGE_FUNCTION_NAME}/*`,
       to: `/.netlify/builders/${IMAGE_FUNCTION_NAME}`,
       status: 200,
-    })  
+    })
   }
 
   if (basePath) {

packages/runtime/src/index.ts

@@ -25,12 +25,7 @@ import {
 import { moveStaticPages, movePublicFiles, patchNextFiles } from './helpers/files'
 import { generateFunctions, setupImageFunction, generatePagesResolver } from './helpers/functions'
 import { generateRedirects, generateStaticRedirects } from './helpers/redirects'
-import {
-  shouldSkip,
-  isNextAuthInstalled,
-  getCustomImageResponseHeaders,
-  getRemotePatterns,
-} from './helpers/utils'
+import { shouldSkip, isNextAuthInstalled, getCustomImageResponseHeaders, getRemotePatterns } from './helpers/utils'
 import {
   verifyNetlifyBuildVersion,
   checkNextSiteHasBuilt,
@@ -69,7 +64,6 @@ const plugin: NetlifyPlugin = {
     netlifyConfig.build.environment.NEXT_PRIVATE_TARGET = 'server'
   },
 
-  // eslint-disable-next-line max-lines-per-function
   async onBuild({
     constants,
     netlifyConfig,