fix: use platform-agnostic paths, and add test to be sure

Author: ascorbic

package.json

@@ -58,8 +58,8 @@
     "chalk": "^4.1.2",
     "fs-extra": "^10.0.0",
     "moize": "^6.1.0",
-    "node-stream-zip": "^1.15.0",
     "node-fetch": "^2.6.5",
+    "node-stream-zip": "^1.15.0",
     "outdent": "^0.8.0",
     "p-limit": "^3.1.0",
     "pathe": "^0.2.0",

src/helpers/functions.js

@@ -1,6 +1,5 @@
-const { join, relative } = require('path')
-
 const { copyFile, ensureDir, writeFile, writeJSON } = require('fs-extra')
+const { join, relative } = require('pathe')
 
 const { HANDLER_FUNCTION_NAME, ODB_FUNCTION_NAME, IMAGE_FUNCTION_NAME } = require('../constants')
 const getHandler = require('../templates/getHandler')

test/index.js

@@ -223,6 +223,30 @@ describe('onBuild()', () => {
     expect(readFileSync(handlerPagesFile, 'utf8')).toMatchSnapshot()
     expect(readFileSync(odbHandlerPagesFile, 'utf8')).toMatchSnapshot()
   })
+
+  test('generates entrypoints with correct references', async () => {
+    const handlerFile = path.join(
+      SAMPLE_PROJECT_DIR,
+      '.netlify',
+      'functions-internal',
+      HANDLER_FUNCTION_NAME,
+      `${HANDLER_FUNCTION_NAME}.js`,
+    )
+    const odbHandlerFile = path.join(
+      SAMPLE_PROJECT_DIR,
+      '.netlify',
+      'functions-internal',
+      ODB_FUNCTION_NAME,
+      `${ODB_FUNCTION_NAME}.js`,
+    )
+    expect(existsSync(handlerFile)).toBeTruthy()
+    expect(existsSync(odbHandlerFile)).toBeTruthy()
+
+    expect(readFileSync(handlerFile, 'utf8')).toMatch(`(config, "../../..", pageRoot, staticManifest)`)
+    expect(readFileSync(odbHandlerFile, 'utf8')).toMatch(`(config, "../../..", pageRoot, staticManifest)`)
+    expect(readFileSync(handlerFile, 'utf8')).toMatch(`require("../../../.next/required-server-files.json")`)
+    expect(readFileSync(odbHandlerFile, 'utf8')).toMatch(`require("../../../.next/required-server-files.json")`)
+  })
 })
 
 describe('onPostBuild', () => {