fix: streamline no-shadow handling

pieh · pieh · commit 66a9670e413a · 2023-05-02T14:06:15.000+02:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -48,6 +48,9 @@ module.exports = {
         'n/no-unsupported-features/es-syntax': 'off',
         '@typescript-eslint/no-extra-semi': 'off',
         'n/no-missing-import': 'off',
+        // https://github.com/typescript-eslint/typescript-eslint/issues/2483
+        'no-shadow': 'off',
+        '@typescript-eslint/no-shadow': 'error',
       },
     },
     {
diff --git a/packages/runtime/src/helpers/types.ts b/packages/runtime/src/helpers/types.ts
@@ -52,8 +52,6 @@ export interface RoutesManifest {
   rewrites: Rewrites
 }
 
-// I have no idea what eslint is up to here but it gives an error
-// eslint-disable-next-line no-shadow
 export const enum ApiRouteType {
   SCHEDULED = 'experimental-scheduled',
   BACKGROUND = 'experimental-background',

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,6 @@ export interface RoutesManifest {`
`52`	`52`	`rewrites: Rewrites`
`53`	`53`	`}`
`54`	`54`
`55`		`-// I have no idea what eslint is up to here but it gives an error`
`56`		`-// eslint-disable-next-line no-shadow`
`57`	`55`	`export const enum ApiRouteType {`
`58`	`56`	`SCHEDULED = 'experimental-scheduled',`
`59`	`57`	`BACKGROUND = 'experimental-background',`