fix: now only custom rewrites are created for background and scheduled functions

Author: nickytonline

packages/runtime/src/helpers/utils.ts

@@ -145,22 +145,25 @@ export const redirectsForNextRouteWithData = ({
   }))
 
 export const getApiRewrites = (basePath: string, apiRoutes: Array<ApiRouteConfig>) => {
-  const apiRewrites = apiRoutes.map((apiRoute) => {
-    const [from] = toNetlifyRoute(`${basePath}${apiRoute.route}`)
-
-    // Scheduled functions can't be invoked directly, so we 404 them.
-    if (apiRoute.config.type === ApiRouteType.SCHEDULED) {
-      return { from, to: '/404.html', status: 404 }
-    }
-    return {
-      from,
-      to: `/.netlify/functions/${getFunctionNameForPage(
-        apiRoute.route,
-        apiRoute.config.type === ApiRouteType.BACKGROUND,
-      )}`,
-      status: 200,
-    }
-  })
+  const apiRewrites = apiRoutes
+    // Only create custom rewrites for API routes that are background or scheduled functions.
+    .filter((apiRoute) => apiRoute.config.type !== undefined)
+    .map((apiRoute) => {
+      const [from] = toNetlifyRoute(`${basePath}${apiRoute.route}`)
+
+      // Scheduled functions can't be invoked directly, so we 404 them.
+      if (apiRoute.config.type === ApiRouteType.SCHEDULED) {
+        return { from, to: '/404.html', status: 404 }
+      }
+      return {
+        from,
+        to: `/.netlify/functions/${getFunctionNameForPage(
+          apiRoute.route,
+          apiRoute.config.type === ApiRouteType.BACKGROUND,
+        )}`,
+        status: 200,
+      }
+    })
 
   return [
     ...apiRewrites,

test/__snapshots__/index.js.snap

@@ -1095,21 +1095,6 @@ Array [
     "status": 200,
     "to": "/.netlify/functions/___netlify-handler",
   },
-  Object {
-    "from": "/api/enterPreview",
-    "status": 200,
-    "to": "/.netlify/functions/_api_enterPreview-handler",
-  },
-  Object {
-    "from": "/api/exitPreview",
-    "status": 200,
-    "to": "/.netlify/functions/_api_exitPreview-handler",
-  },
-  Object {
-    "from": "/api/hello",
-    "status": 200,
-    "to": "/.netlify/functions/_api_hello-handler",
-  },
   Object {
     "from": "/api/hello-background",
     "status": 200,
@@ -1120,21 +1105,6 @@ Array [
     "status": 404,
     "to": "/404.html",
   },
-  Object {
-    "from": "/api/og",
-    "status": 200,
-    "to": "/.netlify/functions/_api_og-handler",
-  },
-  Object {
-    "from": "/api/shows/:id",
-    "status": 200,
-    "to": "/.netlify/functions/_api_shows_id-PARAM-handler",
-  },
-  Object {
-    "from": "/api/shows/:params/*",
-    "status": 200,
-    "to": "/.netlify/functions/_api_shows_params-SPLAT-handler",
-  },
   Object {
     "force": false,
     "from": "/broken-image",