fix: next 10.0.8 changes loadConfig to be async (#105)

* fix: 10.0.8 changes loadConfig to be async

* wip: make literally everything async bc loadConfig

* wip: fix i18n bug, got 10.0.6 tests to pass

* wip: NoN tests pass on 10.0.8 but plugin test chdir fixture issue

* Fix bug with Jest

* fix: delete TO-DO

Co-authored-by: ehmicky <[email protected]>

Author: lindsaylevine

helpers/doesNotNeedPlugin.js

@@ -13,7 +13,7 @@ const doesNotNeedPlugin = async ({ netlifyConfig, packageJson, utils }) => {
   return (
     isStaticExportProject({ build, scripts }) ||
     doesSiteUseNextOnNetlify({ packageJson }) ||
-    !hasCorrectNextConfig({ nextConfigPath, failBuild: utils.build.failBuild })
+    !(await hasCorrectNextConfig({ nextConfigPath, failBuild: utils.build.failBuild }))
   )
 }
 

helpers/hasCorrectNextConfig.js

@@ -1,7 +1,7 @@
 const path = require('path')
 
 // Checks if site has the correct next.cofig.js
-const hasCorrectNextConfig = ({ nextConfigPath, failBuild }) => {
+const hasCorrectNextConfig = async ({ nextConfigPath, failBuild }) => {
   // In the plugin's case, no config is valid because we'll make it ourselves
   if (nextConfigPath === undefined) return true
 
@@ -14,7 +14,7 @@ const hasCorrectNextConfig = ({ nextConfigPath, failBuild }) => {
   const acceptableTargets = ['serverless', 'experimental-serverless-trace']
   let nextConfig
   try {
-    nextConfig = loadConfig(PHASE_PRODUCTION_BUILD, path.resolve('.'))
+    nextConfig = await loadConfig(PHASE_PRODUCTION_BUILD, path.resolve('.'))
   } catch (error) {
     return failBuild('Error loading your next.config.js.', { error })
   }

index.js

@@ -54,7 +54,7 @@ module.exports = {
 
     await makeDir(PUBLISH_DIR)
 
-    nextOnNetlify({ functionsDir: FUNCTIONS_SRC, publishDir: PUBLISH_DIR })
+    await nextOnNetlify({ functionsDir: FUNCTIONS_SRC, publishDir: PUBLISH_DIR })
   },
 }