Merge pull request #640 from kinvolk/dongsu/test-empty-hostname

validation: test validation test with an empty hostname

Author: liangchenye

validation/hostname.go

@@ -1,17 +1,46 @@
 package main
 
 import (
+	"fmt"
+	"runtime"
+
+	"github.com/mndrix/tap-go"
 	"github.com/opencontainers/runtime-tools/validation/util"
 )
 
-func main() {
+func testHostname(t *tap.T, hostname string) error {
 	g, err := util.GetDefaultGenerator()
 	if err != nil {
-		util.Fatal(err)
+		return err
 	}
-	g.SetHostname("hostname-specific")
+
+	g.SetHostname(hostname)
 	err = util.RuntimeInsideValidate(g, nil)
+	t.Ok(err == nil, "hostname is set correctly")
 	if err != nil {
-		util.Fatal(err)
+		t.Diagnosticf("expect: err == nil, actual: err != nil")
+	}
+
+	return nil
+}
+
+func main() {
+	t := tap.New()
+	t.Header(0)
+	defer t.AutoPlan()
+
+	if "linux" != runtime.GOOS {
+		t.Skip(1, fmt.Sprintf("linux-specific namespace test"))
+	}
+
+	hostnames := []string{
+		"",
+		"hostname-specific",
+	}
+
+	for _, h := range hostnames {
+		if err := testHostname(t, h); err != nil {
+			util.Fatal(err)
+		}
 	}
 }