Skip to content

Commit ed3bcb2

Browse files
author
Zhou Hao
authored
Merge pull request #571 from liangchenye/release
don't overwrite hook which has a same path
2 parents 3eba113 + 5cbd8c7 commit ed3bcb2

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

generate/generate.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -914,12 +914,6 @@ func (g *Generator) ClearPreStartHooks() {
914914
// AddPreStartHook add a prestart hook into g.spec.Hooks.Prestart.
915915
func (g *Generator) AddPreStartHook(preStartHook rspec.Hook) error {
916916
g.initSpecHooks()
917-
for i, hook := range g.spec.Hooks.Prestart {
918-
if hook.Path == preStartHook.Path {
919-
g.spec.Hooks.Prestart[i] = preStartHook
920-
return nil
921-
}
922-
}
923917
g.spec.Hooks.Prestart = append(g.spec.Hooks.Prestart, preStartHook)
924918
return nil
925919
}
@@ -935,12 +929,6 @@ func (g *Generator) ClearPostStopHooks() {
935929
// AddPostStopHook adds a poststop hook into g.spec.Hooks.Poststop.
936930
func (g *Generator) AddPostStopHook(postStopHook rspec.Hook) error {
937931
g.initSpecHooks()
938-
for i, hook := range g.spec.Hooks.Poststop {
939-
if hook.Path == postStopHook.Path {
940-
g.spec.Hooks.Poststop[i] = postStopHook
941-
return nil
942-
}
943-
}
944932
g.spec.Hooks.Poststop = append(g.spec.Hooks.Poststop, postStopHook)
945933
return nil
946934
}
@@ -956,12 +944,6 @@ func (g *Generator) ClearPostStartHooks() {
956944
// AddPostStartHook adds a poststart hook into g.spec.Hooks.Poststart.
957945
func (g *Generator) AddPostStartHook(postStartHook rspec.Hook) error {
958946
g.initSpecHooks()
959-
for i, hook := range g.spec.Hooks.Poststart {
960-
if hook.Path == postStartHook.Path {
961-
g.spec.Hooks.Poststart[i] = postStartHook
962-
return nil
963-
}
964-
}
965947
g.spec.Hooks.Poststart = append(g.spec.Hooks.Poststart, postStartHook)
966948
return nil
967949
}

0 commit comments

Comments
 (0)