Skip to content

Commit e43d1ff

Browse files
committed
return ErrorOrNil in bundle validate
Signed-off-by: Liang Chenye <[email protected]>
1 parent 4e8dc67 commit e43d1ff

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

cmd/oci-runtime-tool/validate.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ var bundleValidateCommand = cli.Command{
4444
for _, e := range levelErrors.Warnings {
4545
logrus.Warn(e)
4646
}
47-
return levelErrors.Error
47+
48+
return levelErrors.Error.ErrorOrNil()
4849
}
4950
fmt.Println("Bundle validation succeeded.")
5051
return nil

validate/validate.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -666,15 +666,15 @@ func (v *Validator) CheckAnnotations() (errs error) {
666666
errs = multierror.Append(errs,
667667
specerror.NewError(
668668
specerror.AnnotationsKeyReservedNS,
669-
fmt.Errorf("key %s is reserved", key),
669+
fmt.Errorf("key %q is reserved", key),
670670
rspec.Version))
671671
}
672672

673673
if !reversedDomain.MatchString(key) {
674674
errs = multierror.Append(errs,
675675
specerror.NewError(
676676
specerror.AnnotationsKeyReversedDomain,
677-
fmt.Errorf("key %s SHOULD be named using a reverse domain notation", key),
677+
fmt.Errorf("key %q SHOULD be named using a reverse domain notation", key),
678678
rspec.Version))
679679
}
680680
}

validation/misc_props.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ func main() {
6464
Actions: c.action,
6565
PreCreate: func(r *util.Runtime) error {
6666
r.SetID(containerID)
67-
saveConfig(configFile, c.eSpec)
68-
return nil
67+
return saveConfig(configFile, c.eSpec)
6968
},
7069
PreDelete: func(r *util.Runtime) error {
7170
util.WaitingForStatus(*r, util.LifecycleStatusCreated|util.LifecycleStatusStopped, time.Second*10, time.Second*1)

0 commit comments

Comments
 (0)