Skip to content

Commit d51b421

Browse files
author
Mrunal Patel
authored
Merge pull request #663 from madhanrm/winNamespace
Vendor in windows runtime-spec changes
2 parents 745f940 + fb101d5 commit d51b421

File tree

6 files changed

+77
-9
lines changed

6 files changed

+77
-9
lines changed

Diff for: Godeps/Godeps.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: generate/generate.go

+6
Original file line numberDiff line numberDiff line change
@@ -1537,6 +1537,12 @@ func (g *Generator) SetWindowsNetwork(network rspec.WindowsNetwork) {
15371537
g.Config.Windows.Network = &network
15381538
}
15391539

1540+
// SetWindowsNetworkNamespace sets g.Config.Windows.Network.NetworkNamespace
1541+
func (g *Generator) SetWindowsNetworkNamespace(path string) {
1542+
g.initConfigWindows()
1543+
g.Config.Windows.Network.NetworkNamespace = path
1544+
}
1545+
15401546
// SetWindowsResourcesCPU sets g.Config.Windows.Resources.CPU.
15411547
func (g *Generator) SetWindowsResourcesCPU(cpu rspec.WindowsCPUResources) {
15421548
g.initConfigWindowsResources()

Diff for: man/oci-runtime-tool-generate.1.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,7 @@ read the configuration from `config.json`.
496496

497497
**--windows-network**=""
498498
Specifies network for container.
499-
e.g. --windows-network='{"endpointList": ["7a010682-17e0-4455-a838-02e5d9655fe6"],"allowUnqualifiedDNSQuery": true,"DNSSearchList": ["a.com"],"networkSharedContainerName": "containerName"}'
499+
e.g. --windows-network='{"endpointList": ["7a010682-17e0-4455-a838-02e5d9655fe6"],"allowUnqualifiedDNSQuery": true,"DNSSearchList": ["a.com"],"networkSharedContainerName": "containerName", "networkNamespace" : "15010682-17e0-4455-a838-02e5d9655f00"}'
500500

501501
**--windows-resources-cpu**=""
502502
Specifies cpu for container.

Diff for: validate/validate_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func TestJSONSchema(t *testing.T) {
4343
}{
4444
{
4545
config: &rspec.Spec{},
46-
error: "1 error occurred:\n\n* Version string empty\nRefer to: https://github.com/opencontainers/runtime-spec/blob/v1.0.0/config.md#specification-version",
46+
error: "1 error occurred:\n\n* Version string empty\nRefer to: https://github.com/opencontainers/runtime-spec/blob/v1.0.1-dev/config.md#specification-version",
4747
},
4848
{
4949
config: &rspec.Spec{

Diff for: vendor/github.com/opencontainers/runtime-spec/specs-go/config.go

+65-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: vendor/github.com/opencontainers/runtime-spec/specs-go/version.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)