Skip to content

build: use base ts-config #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 8, 2021
Merged

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Jul 1, 2021

  • uses (and re-uses) base ts-config for both (cjs and esm) builds
  • uses "target": "ES2018" for both (cjs + esm) builds
  • removed ts-config noImplicitAny, part of strict: true (https://www.typescriptlang.org/tsconfig/#noImplicitAny)
  • added ts-config useDefineForClassFields for strict ecma syntax
  • added ts-config forceConsistentCasingInFileNames
  • removed [deprecated] ts-config noUnusedLocals (already covered by eslint)
  • removed ts-config skipLibCheck:true (default: false), for stricter type checks

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #677 (748e646) into main (026eb74) will increase coverage by 2.54%.
The diff coverage is 96.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   93.81%   96.35%   +2.54%     
==========================================
  Files           5       13       +8     
  Lines         291      549     +258     
  Branches       97      192      +95     
==========================================
+ Hits          273      529     +256     
- Misses         16       19       +3     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
src/load.ts 91.58% <91.58%> (ø)
src/transform/paths.ts 92.30% <92.30%> (ø)
src/transform/request.ts 94.44% <94.44%> (ø)
src/utils.ts 96.55% <96.77%> (-1.64%) ⬇️
src/transform/responses.ts 97.36% <97.36%> (ø)
src/transform/parameters.ts 98.00% <98.00%> (ø)
src/index.ts 96.66% <98.03%> (+14.84%) ⬆️
src/transform/index.ts 98.27% <98.27%> (ø)
src/transform/schema.ts 98.98% <98.98%> (ø)
prettier.config.js 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67cba65...748e646. Read the comment docs.

@drwpow drwpow merged commit db04503 into openapi-ts:main Jul 8, 2021
@dnalborczyk dnalborczyk deleted the ts-config-base branch July 8, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants