Skip to content

[string, null] definition is converted to unknown #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
LarsOlt opened this issue Nov 3, 2022 · 2 comments · Fixed by #968
Closed
1 task

[string, null] definition is converted to unknown #969

LarsOlt opened this issue Nov 3, 2022 · 2 comments · Fixed by #968
Labels
3.1 Part of OpenAPI 3.1 bug Something isn't working planned Expected in an upcoming version

Comments

@LarsOlt
Copy link

LarsOlt commented Nov 3, 2022

Description

Source:
image

Output:

image

Expected:

"image-path": string | null

Name Version
openapi-typescript 5.4.1
Node.js 16.18.0
OS + version Win 11

Reproduction

How can this be reproduced / when did the error occur?

I am using the https://developers.themoviedb.org/ OAS API definition.

npx openapi-typescript https://api.stoplight.io/v1/versions/9WaNJfGpnnQ76opqe/export/oas.json --output tmdb-oas.ts

Expected result

(in case it’s not obvious)

Checklist
@LarsOlt
Copy link
Author

LarsOlt commented Nov 3, 2022

Seems to be related to #898 ?

@drwpow drwpow added bug Something isn't working planned Expected in an upcoming version 3.1 Part of OpenAPI 3.1 labels Nov 3, 2022
@drwpow
Copy link
Contributor

drwpow commented Nov 3, 2022

Thank you for raising! v6 will add OpenAPI 3.1 support so will make sure this makes it in.

This was referenced Nov 3, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.1 Part of OpenAPI 3.1 bug Something isn't working planned Expected in an upcoming version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Big honkin‘ refactor, OpenAPI 3.1 features openapi-ts/openapi-typescript
2 participants
@drwpow @LarsOlt