Use unknown instead of any

[andrenarchy]

It would be great if the resulting ts would not use any but unknown instead.

[drwpow]

Thanks for the suggestion. Do you have an example of a schema you’re using, what it’s generating, and what you’d like it to be instead?

Also would you be open to opening a PR for this?

[andrenarchy]

One example is a schema I have with the following property somewhere:

          "presets": {
            "description": "JSON structure containing the preset value for created/updated items.",
            "type": "object",
            "nullable": true
          },

This gets transformed into:

presets?: { [key: string]: any } | null

The use of any is generally discouraged since it can be accessed in any way. But that's not really what we want for a type where we don't have further knowledge. So the better option would be to use unknown for all types that are currently generated as any because then it's up to the user to do further checks on the type. In the above example I'd expect:

presets?: { [key: string]: unknown } | null

See also eslint (which is complaining about any in the recommended rule set) and the TypeScript announcement that says

unknown is the type-safe counterpart of any

which really is the essence I think. :)

[drwpow]

Thanks for providing more info. I also see that #625 was opened to address this. If it’s all the same to people, I don’t see why unknown isn’t an improvement. I’m on board with this change.

[drwpow]

Added in #769!