Skip to content

Document Chinese support #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phk422 opened this issue Feb 22, 2024 · 8 comments
Closed

Document Chinese support #1560

phk422 opened this issue Feb 22, 2024 · 8 comments
Labels
enhancement New feature or request openapi-ts Relevant to the openapi-typescript library PRs welcome PRs are welcome to solve this issue!

Comments

@phk422
Copy link
Contributor

phk422 commented Feb 22, 2024

Hi, @drwpow ! For the convenience of Chinese users, I want the document to support Chinese and I can participate in the construction and translation

@phk422 phk422 added enhancement New feature or request PRs welcome PRs are welcome to solve this issue! openapi-ts Relevant to the openapi-typescript library labels Feb 22, 2024
@drwpow
Copy link
Contributor

drwpow commented Feb 22, 2024

We would love that! Vitepress makes i18n easy; I just haven’t set it up yet. I will make some placeholder documents and let you (and others) contribute as they’re able to.

What would be a good ISO URL path to set up placeholders? /zh/…, /yue/…, or something else?

@drwpow
Copy link
Contributor

drwpow commented Feb 22, 2024

Opened up #1561 for feedback! Please suggest any/all changes. Also see the preview deployment. Ideally you could open up a few PRs against this branch, and we could merge in, just so a couple articles are filled in. Then happy to merge when there’s any content at all, and we can build it over time (doesn’t have to be complete 1st pass or anything)

@phk422
Copy link
Contributor Author

phk422 commented Feb 23, 2024

Hello @drwpow ,Before we get started, I realized when using the light theme, the Get start button on the home page is not visible.
image

@drwpow
Copy link
Contributor

drwpow commented Feb 27, 2024

The button color is set with oklch; does your browser/OS not support that? And if not, what are you using? (I had thought it had wide support now but I guess I was mistaken)

@drwpow
Copy link
Contributor

drwpow commented Feb 27, 2024

Oh! It’s not oklch() that’s the problem; it’s that the color is in the P3 gamut and needs a fallback for non-P3 monitors. Will fix! Thank you.

@phk422
Copy link
Contributor Author

phk422 commented Feb 27, 2024

The button color is set with oklch; does your browser/OS not support that? And if not, what are you using? (I had thought it had wide support now but I guess I was mistaken)

My Google browser hasn't been upgraded for a long time, but when I upgraded to the latest version, it worked fine. Maybe it's a browser version compatibility issue

@drwpow
Copy link
Contributor

drwpow commented Feb 28, 2024

It’s live! 🙌 Thanks so much for all your hard work! 🙂 There are still a few more pages to translate, but I wanted to at least get all the pages you have done up so that the work can happen as you have time to (and also for others to help contribute—maybe this will even inspire other languages). Thanks so much for making this happen ❤️

@drwpow
Copy link
Contributor

drwpow commented Mar 6, 2024

This has been completed! 🎉 While there will always be room for additional PRs and fixes, I think this ticket has served its purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request openapi-ts Relevant to the openapi-typescript library PRs welcome PRs are welcome to solve this issue!
Projects
None yet
Development

No branches or pull requests

2 participants