Skip to content

Commit 50441d0

Browse files
pvanagtmaalPiet van Agtmaal
and
Piet van Agtmaal
authored
Fix empty request / response bodies (#1280)
Co-authored-by: Piet van Agtmaal <[email protected]>
1 parent 7f452fa commit 50441d0

13 files changed

+2809
-885
lines changed

.changeset/mighty-ligers-cheat.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"openapi-typescript": patch
3+
---
4+
5+
Fix invalid typescript for empty request bodies, fix headers being left out when response body is omitted

packages/openapi-fetch/test/v1.d.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,9 @@ export interface paths {
184184
};
185185
responses: {
186186
/** @description No Content */
187-
204: never;
187+
204: {
188+
content: never;
189+
};
188190
500: components["responses"]["Error"];
189191
};
190192
};

packages/openapi-typescript/examples/digital-ocean-api.ts

+37-7
Original file line numberDiff line numberDiff line change
@@ -14340,10 +14340,18 @@ export interface external {
1434014340
"resources/ssh_keys/attributes/ssh_key_fingerprint.yml": string
1434114341
"resources/ssh_keys/attributes/ssh_key_id.yml": number
1434214342
"resources/ssh_keys/attributes/ssh_key_name.yml": string
14343-
"resources/ssh_keys/links/sshKeys_delete_by_fingerprint.yml": never
14344-
"resources/ssh_keys/links/sshKeys_delete_by_id.yml": never
14345-
"resources/ssh_keys/links/sshKeys_get_by_fingerprint.yml": never
14346-
"resources/ssh_keys/links/sshKeys_get_by_id.yml": never
14343+
"resources/ssh_keys/links/sshKeys_delete_by_fingerprint.yml": {
14344+
content: never;
14345+
}
14346+
"resources/ssh_keys/links/sshKeys_delete_by_id.yml": {
14347+
content: never;
14348+
}
14349+
"resources/ssh_keys/links/sshKeys_get_by_fingerprint.yml": {
14350+
content: never;
14351+
}
14352+
"resources/ssh_keys/links/sshKeys_get_by_id.yml": {
14353+
content: never;
14354+
}
1434714355
"resources/ssh_keys/models/sshKeys.yml": {
1434814356
id?: external["resources/ssh_keys/attributes/ssh_key_id.yml"];
1434914357
fingerprint?: external["resources/ssh_keys/attributes/ssh_key_fingerprint.yml"];
@@ -16033,7 +16041,14 @@ export interface external {
1603316041
page?: number;
1603416042
region?: external["shared/attributes/region_slug.yml"];
1603516043
};
16036-
"shared/responses/accepted.yml": never
16044+
"shared/responses/accepted.yml": {
16045+
headers: {
16046+
"ratelimit-limit": external["shared/headers.yml"]["ratelimit-limit"];
16047+
"ratelimit-remaining": external["shared/headers.yml"]["ratelimit-remaining"];
16048+
"ratelimit-reset": external["shared/headers.yml"]["ratelimit-reset"];
16049+
};
16050+
content: never;
16051+
}
1603716052
"shared/responses/bad_request.yml": {
1603816053
headers: {
1603916054
"ratelimit-limit": external["shared/headers.yml"]["ratelimit-limit"];
@@ -16054,8 +16069,23 @@ export interface external {
1605416069
"application/json": external["shared/models/error.yml"];
1605516070
};
1605616071
}
16057-
"shared/responses/no_content_with_content_type.yml": never
16058-
"shared/responses/no_content.yml": never
16072+
"shared/responses/no_content_with_content_type.yml": {
16073+
headers: {
16074+
"ratelimit-limit": external["shared/headers.yml"]["ratelimit-limit"];
16075+
"ratelimit-remaining": external["shared/headers.yml"]["ratelimit-remaining"];
16076+
"ratelimit-reset": external["shared/headers.yml"]["ratelimit-reset"];
16077+
"content-type": external["shared/headers.yml"]["content-type"];
16078+
};
16079+
content: never;
16080+
}
16081+
"shared/responses/no_content.yml": {
16082+
headers: {
16083+
"ratelimit-limit": external["shared/headers.yml"]["ratelimit-limit"];
16084+
"ratelimit-remaining": external["shared/headers.yml"]["ratelimit-remaining"];
16085+
"ratelimit-reset": external["shared/headers.yml"]["ratelimit-reset"];
16086+
};
16087+
content: never;
16088+
}
1605916089
"shared/responses/not_found.yml": {
1606016090
headers: {
1606116091
"ratelimit-limit": external["shared/headers.yml"]["ratelimit-limit"];

0 commit comments

Comments
 (0)