Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

[REQ] Add overload type hints for model new #27

Closed
spacether opened this issue Oct 5, 2022 · 2 comments · Fixed by #185
Closed

[REQ] Add overload type hints for model new #27

spacether opened this issue Oct 5, 2022 · 2 comments · Fixed by #185
Labels
enhancement New feature or request

Comments

@spacether
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Add overload type hints for model new

Describe the solution you'd like

This will enable running mypy on models because the mixin classes will no longer collide!

Describe alternatives you've considered

Additional context
@spacether spacether added the enhancement New feature or request label Nov 8, 2022
@spacether spacether mentioned this issue Jul 5, 2023
Closed
@spacether spacether linked a pull request Jul 5, 2023 that will close this issue
v3 simplifies validation #185
Merged
3 tasks
@spacether
Copy link
Contributor Author

spacether commented Jul 28, 2023 •
edited
Loading

Note: the linked PR moves __new__ functionality into:
SomeSchema.validate or
SomeSchemaDict.__new__
SomeSchemaTuple.__new__
Where

  • SomeSchemaDict is the dict output class one gets from running SomeSchema.validate for dict input
  • SomeSchemaTuple is the tuple output class one gets from running SomeSchema.validate for list or tuple input

@spacether
Copy link
Contributor Author

resolved by 3.0.0 release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v3 simplifies validation openapi-json-schema-tools/openapi-json-schema-generator
1 participant
@spacether