Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

[REQ] Run static checker on generated python code #1

Closed
spacether opened this issue Oct 2, 2022 · 3 comments · Fixed by #187
Closed

[REQ] Run static checker on generated python code #1

spacether opened this issue Oct 2, 2022 · 3 comments · Fixed by #187

Comments

@spacether
Copy link
Contributor

Is your feature request related to a problem? Please describe.

More an opportunity than a problem. Static type analysis is getting more popular in python. This complements testing in helping reduce bugs in the generated code. Additionally it will help make sure that the generated code is typed in a way that helps consumers with their own static analysis.

Describe the solution you'd like

Now that the python-experimental branch doesn't' support python 2 it's possible to run mypy (static analysis) on the code as part of tox. This would require a number of fixes/changes to be applied to the generator to get it working

Describe alternatives you've considered

There are a number of other type checkers available for python but mypy seems the most common at this time

@spacether
Copy link
Contributor Author

One can add missing types from 3rd party packages with:

          - "types-python-dateutil"
          - "types-frozendict"
          - "types-typing-extensions"
          - "types-urllib3"

Per dominodatalab/python-domino@14ff565
thank you @ddl-olsonJD

@spacether
Copy link
Contributor Author

The upcoming v3 release will be closer to being able to run mypy

@spacether spacether linked a pull request Jul 11, 2023 that will close this issue
3 tasks
@spacether
Copy link
Contributor Author

resolved by 3.0.0 release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant