Skip to content

Commit fc070c3

Browse files
committed
fix starlette
1 parent 24ed943 commit fc070c3

File tree

1 file changed

+22
-17
lines changed

1 file changed

+22
-17
lines changed

instrumentation/opentelemetry-instrumentation-starlette/tests/test_starlette_instrumentation.py

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -466,16 +466,18 @@ async def _(websocket: WebSocket) -> None:
466466

467467
return app
468468

469-
470-
@patch.dict(
471-
"os.environ",
472-
{
473-
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SANITIZE_FIELDS: ".*my-secret.*",
474-
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,Regex-Test-Header-.*,Regex-Invalid-Test-Header-.*,.*my-secret.*",
475-
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_RESPONSE: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,my-custom-regex-header-.*,invalid-regex-header-.*,.*my-secret.*",
476-
},
477-
)
478469
class TestHTTPAppWithCustomHeaders(TestBaseWithCustomHeaders):
470+
@patch.dict(
471+
"os.environ",
472+
{
473+
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SANITIZE_FIELDS: ".*my-secret.*",
474+
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,Regex-Test-Header-.*,Regex-Invalid-Test-Header-.*,.*my-secret.*",
475+
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_RESPONSE: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,my-custom-regex-header-.*,invalid-regex-header-.*,.*my-secret.*",
476+
},
477+
)
478+
def setUp(self) -> None:
479+
super().setUp()
480+
479481
def test_custom_request_headers_in_span_attributes(self):
480482
expected = {
481483
"http.request.header.custom_test_header_1": (
@@ -590,15 +592,18 @@ def test_custom_response_headers_not_in_span_attributes(self):
590592
self.assertNotIn(key, server_span.attributes)
591593

592594

593-
@patch.dict(
594-
"os.environ",
595-
{
596-
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SANITIZE_FIELDS: ".*my-secret.*",
597-
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,Regex-Test-Header-.*,Regex-Invalid-Test-Header-.*,.*my-secret.*",
598-
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_RESPONSE: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,my-custom-regex-header-.*,invalid-regex-header-.*,.*my-secret.*",
599-
},
600-
)
601595
class TestWebSocketAppWithCustomHeaders(TestBaseWithCustomHeaders):
596+
@patch.dict(
597+
"os.environ",
598+
{
599+
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SANITIZE_FIELDS: ".*my-secret.*",
600+
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,Regex-Test-Header-.*,Regex-Invalid-Test-Header-.*,.*my-secret.*",
601+
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_RESPONSE: "Custom-Test-Header-1,Custom-Test-Header-2,Custom-Test-Header-3,my-custom-regex-header-.*,invalid-regex-header-.*,.*my-secret.*",
602+
},
603+
)
604+
def setUp(self) -> None:
605+
super().setUp()
606+
602607
def test_custom_request_headers_in_span_attributes(self):
603608
expected = {
604609
"http.request.header.custom_test_header_1": (

0 commit comments

Comments
 (0)