Skip to content

Commit dcb9b2a

Browse files
committed
add urllib3 tests
1 parent 4b56252 commit dcb9b2a

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_integration.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,14 @@ def test_basic_https_success_using_connection_pool(self):
138138

139139
self.assert_success_span(response, self.HTTPS_URL)
140140

141+
def test_schema_url(self):
142+
pool = urllib3.HTTPSConnectionPool("mock")
143+
response = pool.request("GET", "/status/200")
144+
145+
self.assertEqual(b"Hello!", response.data)
146+
span = self.assert_span()
147+
self.assertEqual(span.instrumentation_info.schema_url, "https://opentelemetry.io/schemas/1.11.0")
148+
141149
def test_basic_not_found(self):
142150
url_404 = "http://mock/status/404"
143151
httpretty.register_uri(httpretty.GET, url_404, status=404)

instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_metrics.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,17 @@ def test_str_request_body_size_metrics(self):
155155
],
156156
)
157157

158+
def test_schema_url(self):
159+
self.pool.request("POST", self.HTTP_URL, body="foobar")
160+
161+
resource_metrics = (
162+
self.memory_metrics_reader.get_metrics_data().resource_metrics
163+
)
164+
165+
for metrics in resource_metrics:
166+
for scope_metrics in metrics.scope_metrics:
167+
self.assertEqual(scope_metrics.scope.schema_url, "https://opentelemetry.io/schemas/1.11.0")
168+
158169
def test_bytes_request_body_size_metrics(self):
159170
self.pool.request("POST", self.HTTP_URL, body=b"foobar")
160171

0 commit comments

Comments
 (0)