Skip to content

Commit 5126899

Browse files
committed
Remove [test] package from flask instrumentation
Fixes #2126
1 parent 8daa8ad commit 5126899

File tree

5 files changed

+91
-19
lines changed

5 files changed

+91
-19
lines changed

instrumentation/opentelemetry-instrumentation-flask/pyproject.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ dependencies = [
3636
instruments = [
3737
"flask >= 1.0",
3838
]
39-
test = [
40-
"opentelemetry-instrumentation-flask[instruments]",
41-
"markupsafe==2.1.2",
42-
"opentelemetry-test-utils == 0.45b0.dev",
43-
]
4439

4540
[project.entry-points.opentelemetry_instrumentor]
4641
flask = "opentelemetry.instrumentation.flask:FlaskInstrumentor"
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
click==8.1.7
4+
Deprecated==1.2.14
5+
Flask==2.1.3
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
itsdangerous==2.1.2
9+
Jinja2==3.1.3
10+
MarkupSafe==2.1.2
11+
packaging==23.2
12+
pluggy==1.4.0
13+
py==1.11.0
14+
py-cpuinfo==9.0.0
15+
pytest==7.1.3
16+
pytest-benchmark==4.0.0
17+
tomli==2.0.1
18+
typing_extensions==4.9.0
19+
Werkzeug==2.3.8
20+
wrapt==1.16.0
21+
zipp==3.17.0
22+
-e ../../../opentelemetry-instrumentation
23+
-e ../../../util/opentelemetry-util-http
24+
-e ../../../instrumentation/opentelemetry-instrumentation-wsgi
25+
-e ../../../instrumentation/opentelemetry-instrumentation-flask
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
click==8.1.7
4+
Deprecated==1.2.14
5+
Flask==2.2.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
itsdangerous==2.1.2
9+
Jinja2==3.1.3
10+
MarkupSafe==2.1.2
11+
packaging==23.2
12+
pluggy==1.4.0
13+
py==1.11.0
14+
py-cpuinfo==9.0.0
15+
pytest==7.1.3
16+
pytest-benchmark==4.0.0
17+
tomli==2.0.1
18+
typing_extensions==4.9.0
19+
Werkzeug==2.3.8
20+
wrapt==1.16.0
21+
zipp==3.17.0
22+
-e ../../../opentelemetry-instrumentation
23+
-e ../../../util/opentelemetry-util-http
24+
-e ../../../instrumentation/opentelemetry-instrumentation-wsgi
25+
-e ../../../instrumentation/opentelemetry-instrumentation-flask
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
blinker==1.7.0
4+
click==8.1.7
5+
Deprecated==1.2.14
6+
Flask==3.0.2
7+
importlib-metadata==6.11.0
8+
iniconfig==2.0.0
9+
itsdangerous==2.1.2
10+
Jinja2==3.1.3
11+
MarkupSafe==2.1.2
12+
packaging==23.2
13+
pluggy==1.4.0
14+
py==1.11.0
15+
py-cpuinfo==9.0.0
16+
pytest==7.1.3
17+
pytest-benchmark==4.0.0
18+
tomli==2.0.1
19+
typing_extensions==4.9.0
20+
Werkzeug==3.0.1
21+
wrapt==1.16.0
22+
zipp==3.17.0
23+
-e ../../../opentelemetry-instrumentation
24+
-e ../../../util/opentelemetry-util-http
25+
-e ../../../instrumentation/opentelemetry-instrumentation-wsgi
26+
-e ../../../instrumentation/opentelemetry-instrumentation-flask

tox.ini

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,14 @@ envlist =
8383
pypy3-test-instrumentation-fastapi
8484

8585
; opentelemetry-instrumentation-flask
86-
py3{8,9,10,11}-test-instrumentation-flask-{213,220}
87-
py3{8,9,10,11}-test-instrumentation-flask-{300}
88-
pypy3-test-instrumentation-flask-{213,220}
86+
; The numbers at the end of the environment names
87+
; below mean these dependencies are being used:
88+
; 0: Flask ==2.1.3 Werkzeug <3.0.0
89+
; 1: Flask ==2.2.0 Werkzeug <3.0.0
90+
; 2: Flask >=3.0.0 Werkzeug >=3.0.0
91+
py3{8,9,10,11}-test-instrumentation-flask-{0,1}
92+
py3{8,9,10,11}-test-instrumentation-flask-{2}
93+
pypy3-test-instrumentation-flask-{0,1}
8994

9095
; opentelemetry-instrumentation-urllib
9196
py3{8,9,10,11}-test-instrumentation-urllib
@@ -272,12 +277,6 @@ deps =
272277
falcon-1: falcon ==1.4.1
273278
falcon-2: falcon >=2.0.0,<3.0.0
274279
falcon-3: falcon >=3.0.0,<4.0.0
275-
flask-213: Flask ==2.1.3
276-
flask-213: Werkzeug <3.0.0
277-
flask-220: Flask ==2.2.0
278-
flask-220: Werkzeug <3.0.0
279-
flask-300: Flask >=3.0.0
280-
flask-300: Werkzeug >=3.0.0
281280
grpc: pytest-asyncio
282281
sqlalchemy-11: sqlalchemy>=1.1,<1.2
283282
sqlalchemy-14: aiosqlite
@@ -327,7 +326,7 @@ changedir =
327326
test-instrumentation-elasticsearch-{2,5,6}: instrumentation/opentelemetry-instrumentation-elasticsearch/tests
328327
test-instrumentation-falcon-{1,2,3}: instrumentation/opentelemetry-instrumentation-falcon/tests
329328
test-instrumentation-fastapi: instrumentation/opentelemetry-instrumentation-fastapi/tests
330-
test-instrumentation-flask-{213,220,300}: instrumentation/opentelemetry-instrumentation-flask/tests
329+
test-instrumentation-flask-{0,1,2}: instrumentation/opentelemetry-instrumentation-flask/tests
331330
test-instrumentation-urllib: instrumentation/opentelemetry-instrumentation-urllib/tests
332331
test-instrumentation-urllib3v-{1,2}: instrumentation/opentelemetry-instrumentation-urllib3/tests
333332
test-instrumentation-grpc: instrumentation/opentelemetry-instrumentation-grpc/tests
@@ -391,8 +390,8 @@ commands_pre =
391390

392391
grpc: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
393392

394-
falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,asgi,httpx-{18,21},requests,urllib,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
395-
wsgi,falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi[test]
393+
falcon-{1,2,3},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,asgi,httpx-{18,21},requests,urllib,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
394+
wsgi,falcon-{1,2,3},django-{1,2,3,4},pyramid: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi[test]
396395
asgi,django-{3,4},starlette,fastapi: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asgi[test]
397396

398397
asyncpg: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncpg[test]
@@ -406,7 +405,9 @@ commands_pre =
406405

407406
falcon-{1,2,3}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon[test]
408407

409-
flask-{213,220,300}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
408+
flask-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-0.txt
409+
flask-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-1.txt
410+
flask-2: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-requirements-2.txt
410411

411412
urllib: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
412413

@@ -547,7 +548,7 @@ commands_pre =
547548
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
548549
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon[test]
549550
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-boto[test]
550-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
551+
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-flask
551552
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy[test]
552553
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-cassandra[test]
553554
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-celery[test]

0 commit comments

Comments
 (0)