Skip to content

Commit 5117098

Browse files
authored
Fix expected URL in aiohttp instrumentation test (#1772)
* WIP * Revert "WIP" This reverts commit 3ed4663. * Fix expected URL in aiohttp instrumentation test The underlying cause of the issue here is the update of the yarl package from 1.8.2 to 1.9.1. yarl is used as a dependency in the opentelemetry-instrumentation-aiohttp package but it is not there where the issue happens, but in aiohttp who also has yarl as a dependency. This is why the fix does not touch any relevant part of any opentelemetry-* code, since it is the return value of aiohttp code who now has a different value for the URL. Fixes #1770
1 parent 19fe771 commit 5117098

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def test_status_codes(self):
122122
(span_status, None),
123123
{
124124
SpanAttributes.HTTP_METHOD: "GET",
125-
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path?query=param#foobar",
125+
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path#foobar",
126126
SpanAttributes.HTTP_STATUS_CODE: int(
127127
status_code
128128
),

0 commit comments

Comments
 (0)