remapping feedback

Author: jeremydvoss

opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py

@@ -34,6 +34,12 @@
     TraceContextTextMapPropagator,
 )
 
+# Missing HTTP Semantic Convention Constants for migration
+_SPAN_ATTRIBUTES_NETWORK_PEER_ADDRESS = "network.peer.address"
+_SPAN_ATTRIBUTES_NETWORK_LOCAL_ADDRESS = "network.local.address"
+_SPAN_ATTRIBUTES_NETWORK_PEER_ADDRESS = "network.peer.address"
+_SPAN_ATTRIBUTES_NETWORK_PEER_PORT = "network.peer.port"
+
 propagator = TraceContextTextMapPropagator()
 
 
@@ -171,14 +177,14 @@ def _python_path_without_directory(python_path, directory, path_separator):
     SpanAttributes.HTTP_RESPONSE_CONTENT_LENGTH: SpanAttributes.HTTP_RESPONSE_BODY_SIZE,
     SpanAttributes.NET_HOST_NAME: SpanAttributes.SERVER_ADDRESS,
     SpanAttributes.NET_HOST_PORT: SpanAttributes.SERVER_PORT,
-    SpanAttributes.NET_SOCK_HOST_ADDR: SpanAttributes.SERVER_SOCKET_ADDRESS,
-    SpanAttributes.NET_SOCK_HOST_PORT: SpanAttributes.SERVER_SOCKET_PORT,
+    SpanAttributes.NET_SOCK_HOST_ADDR: _SPAN_ATTRIBUTES_NETWORK_PEER_ADDRESS,
+    SpanAttributes.NET_SOCK_HOST_PORT: _SPAN_ATTRIBUTES_NETWORK_PEER_PORT,
     SpanAttributes.NET_TRANSPORT: SpanAttributes.NETWORK_TRANSPORT,
     SpanAttributes.NET_PROTOCOL_NAME: SpanAttributes.NETWORK_PROTOCOL_NAME,
     SpanAttributes.NET_PROTOCOL_VERSION: SpanAttributes.NETWORK_PROTOCOL_VERSION,
     SpanAttributes.NET_SOCK_FAMILY: SpanAttributes.NETWORK_TYPE,
-    SpanAttributes.NET_PEER_IP: SpanAttributes.CLIENT_SOCKET_ADDRESS,
-    SpanAttributes.NET_HOST_IP: SpanAttributes.SERVER_SOCKET_ADDRESS,
+    SpanAttributes.NET_PEER_IP: _SPAN_ATTRIBUTES_NETWORK_PEER_ADDRESS,
+    SpanAttributes.NET_HOST_IP: _SPAN_ATTRIBUTES_NETWORK_LOCAL_ADDRESS,
     SpanAttributes.HTTP_SERVER_NAME: SpanAttributes.SERVER_ADDRESS,
     SpanAttributes.HTTP_RETRY_COUNT: SpanAttributes.HTTP_RESEND_COUNT,
     SpanAttributes.HTTP_REQUEST_CONTENT_LENGTH_UNCOMPRESSED: SpanAttributes.HTTP_REQUEST_BODY_SIZE,