Skip to content

Commit 1bf999e

Browse files
committed
lint fixes
1 parent 6f6aae8 commit 1bf999e

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

instrumentation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,7 @@ def _trace_postrun(self, *args, **kwargs):
191191
activation.__exit__(None, None, None)
192192
utils.detach_span(task, task_id)
193193
self.update_task_start_time(task_id)
194-
labels = {
195-
'task': task.name,
196-
'worker': task.request.hostname
197-
}
194+
labels = {"task": task.name, "worker": task.request.hostname}
198195
self._record_histograms(task_id, labels)
199196

200197
def _trace_before_publish(self, *args, **kwargs):
@@ -291,13 +288,18 @@ def _trace_retry(*args, **kwargs):
291288

292289
def update_task_start_time(self, task_id):
293290
cur_time = default_timer()
294-
elapsed_time = cur_time - self.task_id_to_start_time[
295-
task_id] if task_id in self.task_id_to_start_time else cur_time
291+
elapsed_time = (
292+
cur_time - self.task_id_to_start_time[task_id]
293+
if task_id in self.task_id_to_start_time
294+
else cur_time
295+
)
296296
self.task_id_to_start_time[task_id] = elapsed_time
297297

298298
def _record_histograms(self, task_id, metric_attributes):
299299
self.metrics["flower.task.runtime.seconds"].record(
300-
self.task_id_to_start_time.get(task_id), attributes=metric_attributes)
300+
self.task_id_to_start_time.get(task_id),
301+
attributes=metric_attributes,
302+
)
301303

302304
def create_celery_metrics(self, meter) -> None:
303305
self.metrics = {

instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@
1717
class TestMetrics(TestBase):
1818
def setUp(self):
1919
super().setUp()
20-
self._worker = app.Worker(app=app, pool="solo", concurrency=1,
21-
hostname='celery@akochavi')
20+
self._worker = app.Worker(
21+
app=app, pool="solo", concurrency=1, hostname="celery@akochavi"
22+
)
2223
self._thread = threading.Thread(target=self._worker.start)
2324
self._thread.daemon = True
2425
self._thread.start()
@@ -95,15 +96,13 @@ def test_basic_metric(self):
9596

9697
task_runtime = metrics[0]
9798
print(task_runtime)
98-
self.assertEqual(
99-
task_runtime.name, "flower.task.runtime.seconds"
100-
)
99+
self.assertEqual(task_runtime.name, "flower.task.runtime.seconds")
101100
self.assert_metric_expected(
102101
task_runtime,
103102
task_runtime_estimated,
104103
{
105-
'task': 'tests.celery_test_tasks.task_add',
106-
'worker': 'celery@akochavi',
104+
"task": "tests.celery_test_tasks.task_add",
105+
"worker": "celery@akochavi",
107106
},
108107
est_delta=200,
109108
)

0 commit comments

Comments
 (0)