Skip to content

Commit d15830d

Browse files
authored
[chore][golangci-lint] Remove gosec excludes (#33574)
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The upstream issue was fixed by golangci/golangci-lint#4748, which was included in release [`v1.59.0`](https://github.com/golangci/golangci-lint/releases/tag/v1.59.0) of `golangci-lint`. From local testing, we're pulling version `v1.59.1` of `golangci-lint`, so the issue should be resolved. Local runtime with excludes: ``` $ .tools/golangci-lint run -v --enable-only gosec ... INFO Execution took 10.927544867s INFO Execution took 8.011302204s INFO Execution took 7.716441258s INFO Execution took 7.441336833s ``` Local runtime without excludes: ``` $ .tools/golangci-lint run -v --enable-only gosec ... INFO Execution took 9.780250262s INFO Execution took 8.175492516s INFO Execution took 7.550060974s INFO Execution took 7.526585686s ``` Note: I ran `.tools/golangci-lint cache clean` between each test to clean the cache and keep results as consistent as possible. I admit that I don't know why the values keep going down with every run, the cache cleaning command may not entirely be working. **Link to tracking Issue:** <Issue number if applicable> These excludes were introduced in #33192 I've opened a PR in core for this issue as well: open-telemetry/opentelemetry-collector#10411
1 parent 8522b4e commit d15830d

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

.golangci.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,6 @@ linters-settings:
132132
predeclared:
133133
ignore: copy
134134

135-
gosec:
136-
excludes:
137-
# https://github.com/golangci/golangci-lint/issues/4735
138-
- G601
139-
# https://github.com/golangci/golangci-lint/issues/4735
140-
- G113
141-
142135
linters:
143136
enable:
144137
- decorder

0 commit comments

Comments
 (0)