Skip to content

Commit 3c3e9c8

Browse files
authored
feat(flagd): use test-harness version number for integration tests (#120)
* feat(flagd): use test-harness version number for integration tests Signed-off-by: Simon Schrottner <[email protected]> * fixup: migrating to pathlib Signed-off-by: Simon Schrottner <[email protected]> --------- Signed-off-by: Simon Schrottner <[email protected]>
1 parent 41d0ad8 commit 3c3e9c8

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

.gitmodules

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
[submodule "providers/openfeature-provider-flagd/test-harness"]
55
path = providers/openfeature-provider-flagd/openfeature/test-harness
66
url = [email protected]:open-feature/flagd-testbed.git
7+
branch = v0.5.18
78
[submodule "providers/openfeature-provider-flagd/spec"]
89
path = providers/openfeature-provider-flagd/openfeature/spec
910
url = https://github.com/open-feature/spec

providers/openfeature-provider-flagd/tests/e2e/flagd_container.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import time
2+
from pathlib import Path
23

34
import grpc
45
from grpc_health.v1 import health_pb2, health_pb2_grpc
@@ -11,11 +12,13 @@
1112
class FlagdContainer(DockerContainer):
1213
def __init__(
1314
self,
14-
image: str = "ghcr.io/open-feature/flagd-testbed:v0.5.15",
15+
image: str = "ghcr.io/open-feature/flagd-testbed",
1516
port: int = 8013,
1617
**kwargs,
1718
) -> None:
18-
super().__init__(image, **kwargs)
19+
path = Path(__file__).parents[2] / "openfeature/test-harness/version.txt"
20+
data = path.read_text().rstrip()
21+
super().__init__(f"{image}:v{data}", **kwargs)
1922
self.port = port
2023
self.with_exposed_ports(self.port, HEALTH_CHECK)
2124

providers/openfeature-provider-flagd/tests/e2e/test_rpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def port():
2222

2323
@pytest.fixture(autouse=True, scope="module")
2424
def image():
25-
return "ghcr.io/open-feature/flagd-testbed:v0.5.13"
25+
return "ghcr.io/open-feature/flagd-testbed"
2626

2727

2828
scenarios(

providers/openfeature-provider-flagd/tests/e2e/test_rpc_reconnect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def port():
2222

2323
@pytest.fixture(autouse=True, scope="module")
2424
def image():
25-
return "ghcr.io/open-feature/flagd-testbed-unstable:v0.5.13"
25+
return "ghcr.io/open-feature/flagd-testbed-unstable"
2626

2727

2828
scenarios(

0 commit comments

Comments
 (0)