Avoid matching multipart parameters annotated with @ModelAttribute

The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>

Author: onobc

src/main/java/org/springframework/data/web/ProxyingHandlerMethodArgumentResolver.java

@@ -36,11 +36,13 @@
 import org.springframework.web.context.request.NativeWebRequest;
 import org.springframework.web.method.annotation.ModelAttributeMethodProcessor;
 import org.springframework.web.method.support.HandlerMethodArgumentResolver;
+import org.springframework.web.multipart.support.MultipartResolutionDelegate;
 
 /**
  * {@link HandlerMethodArgumentResolver} to create Proxy instances for interface based controller method parameters.
  *
  * @author Oliver Gierke
+ * @author Chris Bono
  * @since 1.10
  */
 public class ProxyingHandlerMethodArgumentResolver extends ModelAttributeMethodProcessor
@@ -88,9 +90,9 @@ public boolean supportsParameter(MethodParameter parameter) {
 			return false;
 		}
 
-		// Annotated parameter
-		if (parameter.getParameterAnnotation(ProjectedPayload.class) != null
-				|| parameter.getParameterAnnotation(ModelAttribute.class) != null) {
+		// Annotated parameter (excluding multipart @ModelAttribute)
+		if (parameter.hasParameterAnnotation(ProjectedPayload.class) ||
+				(parameter.hasParameterAnnotation(ModelAttribute.class) && !MultipartResolutionDelegate.isMultipartArgument(parameter))) {
 			return true;
 		}
 

src/test/java/org/springframework/data/web/ProxyingHandlerMethodArgumentResolverUnitTests.java

@@ -27,11 +27,13 @@
 import org.springframework.core.convert.support.DefaultConversionService;
 import org.springframework.util.ReflectionUtils;
 import org.springframework.web.bind.annotation.ModelAttribute;
+import org.springframework.web.multipart.MultipartFile;
 
 /**
  * Unit tests for {@link ProxyingHandlerMethodArgumentResolver}.
  *
  * @author Oliver Gierke
+ * @author Chris Bono
  * @soundtrack Karlijn Langendijk & Sönke Meinen - Englishman In New York (Sting,
  *             https://www.youtube.com/watch?v=O7LZsqrnaaA)
  */
@@ -88,6 +90,14 @@ void doesSupportAtModelAttribute() throws Exception {
 		assertThat(resolver.supportsParameter(parameter)).isTrue();
 	}
 
+	@Test // GH-3258
+	void doesNotSupportAtModelAttributeForMultipartParam() throws Exception {
+
+		var parameter = getParameter("withModelAttributeMultipart", MultipartFile.class);
+
+		assertThat(resolver.supportsParameter(parameter)).isFalse();
+	}
+
 	private static MethodParameter getParameter(String methodName, Class<?> parameterType) {
 
 		var method = ReflectionUtils.findMethod(Controller.class, methodName, parameterType);
@@ -112,5 +122,7 @@ interface Controller {
 		void withForeignAnnotation(@Autowired SampleInterface param);
 
 		void withModelAttribute(@ModelAttribute SampleInterface param);
+
+		void withModelAttributeMultipart(@ModelAttribute MultipartFile file);
 	}
 }