Merge #1509

1509: Update golangci, trying to fix lint r=Kay-Zee a=Kay-Zee

This updates the golangci action to just use the latest v2 action, which is recommended for the action.

Also, skipping the PKG cache because of all the File Exists error. Will have to follow: golangci/golangci-lint-action#244 to see when this is resolved. (though lint is one of the faster jobs, so it's fine even if we skip the cache)

Lastly, I'm suggesting we skip the `unused` lint for TEST FILES ONLY, as there are many cases where we want to use `t.Skip()` to quarantine, but then it causes "unused" errors. This will resolve those cases and better allow us to use `t.Skip()`

Co-authored-by: Kay-Zee <[email protected]>

Author: bors[bot]

.github/workflows/ci.yml

@@ -26,11 +26,13 @@ jobs:
     - name: Build relic
       run: make crypto/relic/build
     - name: Run golangci-lint
-      uses: golangci/golangci-lint-action@v2.3.0
+      uses: golangci/golangci-lint-action@v2
       with:
         # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
         version: v1.41
         args: -v --build-tags relic
+        # https://github.com/golangci/golangci-lint-action/issues/244
+        skip-pkg-cache: true
     - name: Run ShellCheck
       uses: ludeeus/action-shellcheck@master
       with:

.golangci.yml

@@ -27,4 +27,4 @@ issues:
   exclude-rules:
     - path: _test\.go # disable some linters on test files
       linters:
-        - unused
+        - unused