rename: Fingerprint->StaticID

Author: jordanschalm

engine/collection/ingest/engine.go

@@ -261,8 +261,8 @@ func (e *Engine) onTransaction(originID flow.Identifier, tx *flow.TransactionBod
 		return fmt.Errorf("could not get cluster responsible for tx: %x", txID)
 	}
 
-	localClusterFingerPrint := localCluster.Fingerprint()
-	txClusterFingerPrint := txCluster.Fingerprint()
+	localClusterFingerPrint := localCluster.StaticID()
+	txClusterFingerPrint := txCluster.StaticID()
 	log = log.With().
 		Hex("local_cluster", logging.ID(localClusterFingerPrint)).
 		Hex("tx_cluster", logging.ID(txClusterFingerPrint)).

integration/tests/collection/ingress_test.go

@@ -203,7 +203,7 @@ func (suite *IngressSuite) TestTxIngressMultiCluster_CorrectCluster() {
 	// ensure the transaction IS NOT included in other cluster collections
 	for _, cluster := range clusters {
 		// skip the target cluster
-		if cluster.Fingerprint() == targetCluster.Fingerprint() {
+		if cluster.StaticID() == targetCluster.StaticID() {
 			continue
 		}
 
@@ -292,7 +292,7 @@ func (suite *IngressSuite) TestTxIngressMultiCluster_OtherCluster() {
 	// ensure the transaction IS NOT included in other cluster collections
 	for _, cluster := range clusters {
 		// skip the target cluster
-		if cluster.Fingerprint() == targetCluster.Fingerprint() {
+		if cluster.StaticID() == targetCluster.StaticID() {
 			continue
 		}
 

integration/tests/collection/suite.go

@@ -188,7 +188,7 @@ func (suite *CollectorSuite) TxForCluster(target flow.IdentityList) *sdk.Transac
 		require.Nil(suite.T(), err)
 		routed, ok := clusters.ByTxID(convert.IDFromSDK(tx.ID()))
 		require.True(suite.T(), ok)
-		if routed.Fingerprint() == target.Fingerprint() {
+		if routed.StaticID() == target.StaticID() {
 			break
 		}
 	}

model/flow/cluster.go

@@ -116,9 +116,9 @@ func (cl ClusterList) ByNodeID(nodeID Identifier) (IdentityList, uint, bool) {
 
 // IndexOf returns the index of the given cluster.
 func (cl ClusterList) IndexOf(cluster IdentityList) (uint, bool) {
-	clusterFingerprint := cluster.Fingerprint()
+	clusterFingerprint := cluster.StaticID()
 	for index, other := range cl {
-		if other.Fingerprint() == clusterFingerprint {
+		if other.StaticID() == clusterFingerprint {
 			return uint(index), true
 		}
 	}

model/flow/identity.go

@@ -397,7 +397,10 @@ func (il IdentityList) PublicStakingKeys() []crypto.PublicKey {
 	return pks
 }
 
-func (il IdentityList) Fingerprint() Identifier {
+// StaticID uniquely identifies a list of identities, by node ID. This can be used
+// to perpetually identify a group of nodes, even if mutable fields of some nodes
+// are changed, as node IDs are immutable.
+func (il IdentityList) StaticID() Identifier {
 	return GetIDs(il).Fingerprint()
 }
 

state/protocol/badger/snapshot_test.go

@@ -204,7 +204,7 @@ func TestClusters(t *testing.T) {
 			actual := actualClusters[i]
 
 			assert.Equal(t, len(expected), len(actual))
-			assert.Equal(t, expected.Fingerprint(), actual.Fingerprint())
+			assert.Equal(t, expected.StaticID(), actual.StaticID())
 		}
 	})
 }

utils/unittest/cluster.go

@@ -36,7 +36,7 @@ func AlterTransactionForCluster(tx flow.TransactionBody, clusters flow.ClusterLi
 			panic(fmt.Sprintf("unable to find cluster by txID: %x", tx.ID()))
 		}
 
-		if routed.Fingerprint() == target.Fingerprint() {
+		if routed.StaticID() == target.StaticID() {
 			return tx
 		}
 	}