fix obvious dotty compile errors

Author: giabao

akka-testkit/src/main/scala/akka/testkit/TestKit.scala

@@ -1033,7 +1033,7 @@ object TestProbe {
 }
 
 trait ImplicitSender { this: TestKitBase =>
-  implicit def self = testActor
+  implicit def self: ActorRef = testActor
 }
 
 trait DefaultTimeout { this: TestKitBase =>

akka-testkit/src/test/scala/akka/testkit/AkkaSpec.scala

@@ -45,7 +45,7 @@ object AkkaSpec {
 
   def mapToConfig(map: Map[String, Any]): Config = {
     import akka.util.ccompat.JavaConverters._
-    ConfigFactory.parseMap(map.asJava)
+    ConfigFactory.parseMap(map.asInstanceOf[Map[String, AnyRef]].asJava)
   }
 
   def testNameFromCallStack(classToStartFrom: Class[_]): String = {
@@ -100,7 +100,7 @@ abstract class AkkaSpec(_system: ActorSystem)
     with TypeCheckedTripleEquals
     with ScalaFutures {
 
-  implicit val patience = PatienceConfig(testKitSettings.DefaultTimeout.duration, Span(100, Millis))
+  implicit val patience: PatienceConfig = PatienceConfig(testKitSettings.DefaultTimeout.duration, Span(100, Millis))
 
   def this(config: Config) =
     this(
@@ -118,12 +118,12 @@ abstract class AkkaSpec(_system: ActorSystem)
 
   override val invokeBeforeAllAndAfterAllEvenIfNoTestsAreExpected = true
 
-  final override def beforeAll: Unit = {
+  final override def beforeAll(): Unit = {
     startCoroner()
     atStartup()
   }
 
-  final override def afterAll: Unit = {
+  final override def afterAll(): Unit = {
     beforeTermination()
     shutdown()
     afterTermination()

akka-testkit/src/test/scala/akka/testkit/DefaultTimeoutSpec.scala

@@ -11,9 +11,9 @@ import org.scalatest.wordspec.AnyWordSpec
 
 class DefaultTimeoutSpec extends AnyWordSpec with Matchers with BeforeAndAfterAll with TestKitBase with DefaultTimeout {
 
-  implicit lazy val system = ActorSystem("AkkaCustomSpec")
+  implicit val system: ActorSystem = ActorSystem("AkkaCustomSpec")
 
-  override def afterAll = system.terminate
+  override def afterAll() = system.terminate()
 
   "A spec with DefaultTimeout" should {
     "use timeout from settings" in {

akka-testkit/src/test/scala/akka/testkit/ImplicitSenderSpec.scala

@@ -11,9 +11,9 @@ import org.scalatest.wordspec.AnyWordSpec
 
 class ImplicitSenderSpec extends AnyWordSpec with Matchers with BeforeAndAfterAll with TestKitBase with ImplicitSender {
 
-  implicit lazy val system = ActorSystem("AkkaCustomSpec")
+  implicit val system: ActorSystem = ActorSystem("AkkaCustomSpec")
 
-  override def afterAll = system.terminate
+  override def afterAll() = system.terminate()
 
   "An ImplicitSender" should {
     "have testActor as its self" in {

akka-testkit/src/test/scala/akka/testkit/TestActorRefSpec.scala

@@ -42,11 +42,11 @@ object TestActorRefSpec {
     def receiveT = {
       case "complexRequest" => {
         replyTo = sender()
-        val worker = TestActorRef(Props[WorkerActor])
+        val worker = TestActorRef(Props[WorkerActor]())
         worker ! "work"
       }
       case "complexRequest2" =>
-        val worker = TestActorRef(Props[WorkerActor])
+        val worker = TestActorRef(Props[WorkerActor]())
         worker ! sender()
       case "workDone"      => replyTo ! "complexReply"
       case "simpleRequest" => sender() ! "simpleReply"
@@ -143,7 +143,7 @@ class TestActorRefSpec extends AkkaSpec("disp1.type=Dispatcher") with BeforeAndA
     }
 
     "support reply via sender()" in {
-      val serverRef = TestActorRef(Props[ReplyActor])
+      val serverRef = TestActorRef(Props[ReplyActor]())
       val clientRef = TestActorRef(Props(classOf[SenderActor], serverRef))
 
       counter = 4
@@ -169,7 +169,7 @@ class TestActorRefSpec extends AkkaSpec("disp1.type=Dispatcher") with BeforeAndA
 
     "stop when sent a poison pill" in {
       EventFilter[ActorKilledException]().intercept {
-        val a = TestActorRef(Props[WorkerActor])
+        val a = TestActorRef(Props[WorkerActor]())
         system.actorOf(Props(new Actor {
           context.watch(a)
           def receive = {
@@ -251,7 +251,7 @@ class TestActorRefSpec extends AkkaSpec("disp1.type=Dispatcher") with BeforeAndA
     }
 
     "allow override of dispatcher" in {
-      val a = TestActorRef(Props[WorkerActor].withDispatcher("disp1"))
+      val a = TestActorRef(Props[WorkerActor]().withDispatcher("disp1"))
       a.underlying.dispatcher.getClass should ===(classOf[Dispatcher])
     }
 
@@ -323,24 +323,24 @@ class TestActorRefSpec extends AkkaSpec("disp1.type=Dispatcher") with BeforeAndA
     }
 
     "allow creation of a TestActorRef with a default supervisor with Props" in {
-      val ref = TestActorRef[WorkerActor](Props[WorkerActor])
+      val ref = TestActorRef[WorkerActor](Props[WorkerActor]())
       ref.underlyingActor.supervisor should be(system.asInstanceOf[ActorSystemImpl].guardian)
     }
 
     "allow creation of a TestActorRef with a default supervisor and specified name with Props" in {
-      val ref = TestActorRef[WorkerActor](Props[WorkerActor], "specificPropsActor")
+      val ref = TestActorRef[WorkerActor](Props[WorkerActor](), "specificPropsActor")
       ref.underlyingActor.name should be("specificPropsActor")
     }
 
     "allow creation of a TestActorRef with a specified supervisor with Props" in {
       val parent = TestActorRef[ReplyActor]
-      val ref = TestActorRef[WorkerActor](Props[WorkerActor], parent)
+      val ref = TestActorRef[WorkerActor](Props[WorkerActor](), parent)
       ref.underlyingActor.supervisor should be(parent)
     }
 
     "allow creation of a TestActorRef with a specified supervisor and specified name with Props" in {
       val parent = TestActorRef[ReplyActor]
-      val ref = TestActorRef[WorkerActor](Props[WorkerActor], parent, "specificSupervisedPropsActor")
+      val ref = TestActorRef[WorkerActor](Props[WorkerActor](), parent, "specificSupervisedPropsActor")
       ref.underlyingActor.name should be("specificSupervisedPropsActor")
       ref.underlyingActor.supervisor should be(parent)
     }

akka-testkit/src/test/scala/akka/testkit/TestActorsSpec.scala

@@ -4,6 +4,8 @@
 
 package akka.testkit
 
+import akka.actor.actorRef2Scala
+
 class TestActorsSpec extends AkkaSpec with ImplicitSender {
 
   import TestActors.{ echoActorProps, forwardActorProps }

akka-testkit/src/test/scala/akka/testkit/TestFSMRefSpec.scala

@@ -45,7 +45,7 @@ class TestFSMRefSpec extends AkkaSpec {
       val fsm = TestFSMRef(new Actor with FSM[Int, Null] {
         startWith(1, null)
         when(1) {
-          case _ => stay
+          case _ => stay()
         }
       }, "test-fsm-ref-2")
       fsm.isTimerActive("test") should ===(false)
@@ -65,7 +65,7 @@ class TestFSMRefSpec extends AkkaSpec {
     class TestFSMActor extends Actor with FSM[Int, Null] {
       startWith(1, null)
       when(1) {
-        case _ => stay
+        case _ => stay()
       }
       val supervisor = context.parent
       val name = context.self.path.name