Skip to content

Commit 3700c41

Browse files
fix(deps): update dependency @octokit/types to v14 (#731)
* fix(deps): update dependency @octokit/types to v14 * fix(types): add missing properties * fix(types): add a strict omit type * update packages * update packages --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: wolfy1339 <[email protected]>
1 parent fcfe306 commit 3700c41

File tree

5 files changed

+147
-55
lines changed

5 files changed

+147
-55
lines changed

package-lock.json

Lines changed: 133 additions & 49 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@
2727
"license": "MIT",
2828
"dependencies": {
2929
"@octokit/auth-token": "^5.0.0",
30-
"@octokit/graphql": "^8.1.2",
31-
"@octokit/request": "^9.2.1",
32-
"@octokit/request-error": "^6.1.7",
33-
"@octokit/types": "^13.6.2",
30+
"@octokit/graphql": "^8.2.2",
31+
"@octokit/request": "^9.2.3",
32+
"@octokit/request-error": "^6.1.8",
33+
"@octokit/types": "^14.0.0",
3434
"before-after-hook": "^3.0.2",
3535
"universal-user-agent": "^7.0.0"
3636
},

src/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import type {
1212
OctokitPlugin,
1313
RequestParameters,
1414
ReturnTypeOf,
15+
StrictOmit,
1516
UnionToIntersection,
1617
} from "./types.js";
1718
import { VERSION } from "./version.js";
@@ -81,7 +82,10 @@ export class Octokit {
8182

8283
constructor(options: OctokitOptions = {}) {
8384
const hook = new Hook.Collection<Hooks>();
84-
const requestDefaults: Required<RequestParameters> = {
85+
const requestDefaults: StrictOmit<
86+
Required<RequestParameters>,
87+
"query" | "operationName"
88+
> = {
8589
baseUrl: request.endpoint.DEFAULTS.baseUrl,
8690
headers: {},
8791
request: Object.assign({}, options.request, {

src/types.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,8 @@ export type Hooks = {
6363
Error: unknown;
6464
};
6565
};
66+
export type StrictOmit<T, K extends keyof T> = {
67+
[P in keyof T as P extends K ? never : P]: T[P];
68+
} & {
69+
[parameter: string]: unknown;
70+
};

test/request.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ describe("octokit.request()", () => {
116116
accept: "application/vnd.github.v3.raw",
117117
"user-agent": userAgent,
118118
},
119-
overwriteRoutes: false,
120119
},
121120
);
122121

0 commit comments

Comments
 (0)