Skip to content

Commit 512841f

Browse files
committed
Remove [test] packages from instrumentations
Fixes open-telemetry#2126
1 parent f2c536e commit 512841f

File tree

5 files changed

+43
-20
lines changed

5 files changed

+43
-20
lines changed

instrumentation/opentelemetry-instrumentation-flask/pyproject.toml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,8 @@ dependencies = [
3535

3636
[project.optional-dependencies]
3737
instruments = [
38-
"werkzeug < 3.0.0",
3938
"flask >= 1.0",
4039
]
41-
test = [
42-
"opentelemetry-instrumentation-flask[instruments]",
43-
"markupsafe==2.1.2",
44-
"opentelemetry-test-utils == 0.44b0.dev",
45-
]
4640

4741
[project.entry-points.opentelemetry_instrumentor]
4842
flask = "opentelemetry.instrumentation.flask:FlaskInstrumentor"
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
#!/bin/bash
2+
3+
pip install -e ../../../opentelemetry-instrumentation
4+
pip install -e ../../../util/opentelemetry-util-http
5+
pip install -e ../../../instrumentation/opentelemetry-instrumentation-wsgi
6+
pip install "flask==2.1.3"
7+
pip install "werkzeug<3.0.0"
8+
9+
pip install -e ../../../instrumentation/opentelemetry-instrumentation-flask
10+
11+
pip freeze
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
#!/bin/bash
2+
3+
pip install -e ../../../opentelemetry-instrumentation
4+
pip install -e ../../../util/opentelemetry-util-http
5+
pip install -e ../../../instrumentation/opentelemetry-instrumentation-wsgi
6+
pip install "flask==2.2.0"
7+
pip install "werkzeug<3.0.0"
8+
9+
pip install -e ../../../instrumentation/opentelemetry-instrumentation-flask
10+
11+
pip freeze
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
#!/bin/bash
2+
3+
pip install -e ../../../opentelemetry-instrumentation
4+
pip install -e ../../../util/opentelemetry-util-http
5+
pip install -e ../../../instrumentation/opentelemetry-instrumentation-wsgi
6+
pip install "flask>=3.0.0"
7+
pip install "werkzeug>=3.0.0"
8+
9+
pip install -e ../../../instrumentation/opentelemetry-instrumentation-flask
10+
11+
pip freeze

tox.ini

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ envlist =
8383
pypy3-test-instrumentation-fastapi
8484

8585
; opentelemetry-instrumentation-flask
86-
py3{7,8,9,10,11}-test-instrumentation-flask-{213,220}
87-
py3{8,9,10,11}-test-instrumentation-flask-{300}
88-
pypy3-test-instrumentation-flask-{213,220}
86+
py3{7,8,9,10,11}-test-instrumentation-flask-{0,1}
87+
py3{8,9,10,11}-test-instrumentation-flask-{2}
88+
pypy3-test-instrumentation-flask-{0,1}
8989

9090
; opentelemetry-instrumentation-urllib
9191
py3{7,8,9,10,11}-test-instrumentation-urllib
@@ -268,12 +268,6 @@ deps =
268268
falcon-1: falcon ==1.4.1
269269
falcon-2: falcon >=2.0.0,<3.0.0
270270
falcon-3: falcon >=3.0.0,<4.0.0
271-
flask-213: Flask ==2.1.3
272-
flask-213: Werkzeug <3.0.0
273-
flask-220: Flask ==2.2.0
274-
flask-220: Werkzeug <3.0.0
275-
flask-300: Flask >=3.0.0
276-
flask-300: Werkzeug >=3.0.0
277271
grpc: pytest-asyncio
278272
sqlalchemy-11: sqlalchemy>=1.1,<1.2
279273
sqlalchemy-14: aiosqlite
@@ -323,7 +317,7 @@ changedir =
323317
test-instrumentation-elasticsearch-{2,5,6}: instrumentation/opentelemetry-instrumentation-elasticsearch/tests
324318
test-instrumentation-falcon-{1,2,3}: instrumentation/opentelemetry-instrumentation-falcon/tests
325319
test-instrumentation-fastapi: instrumentation/opentelemetry-instrumentation-fastapi/tests
326-
test-instrumentation-flask-{213,220,300}: instrumentation/opentelemetry-instrumentation-flask/tests
320+
test-instrumentation-flask-{0,1,2}: instrumentation/opentelemetry-instrumentation-flask/tests
327321
test-instrumentation-urllib: instrumentation/opentelemetry-instrumentation-urllib/tests
328322
test-instrumentation-urllib3v-{1,2}: instrumentation/opentelemetry-instrumentation-urllib3/tests
329323
test-instrumentation-grpc: instrumentation/opentelemetry-instrumentation-grpc/tests
@@ -385,8 +379,8 @@ commands_pre =
385379

386380
grpc: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
387381

388-
falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,asgi,httpx-{18,21},requests,urllib,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
389-
wsgi,falcon-{1,2,3},flask-{213,220,300},django-{1,2,3,4},pyramid: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi[test]
382+
falcon-{1,2,3},django-{1,2,3,4},pyramid,tornado,starlette,fastapi,aiohttp,asgi,httpx-{18,21},requests,urllib,urllib3v-{1,2},wsgi: pip install {toxinidir}/util/opentelemetry-util-http
383+
wsgi,falcon-{1,2,3},django-{1,2,3,4},pyramid: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi[test]
390384
asgi,django-{3,4},starlette,fastapi: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asgi[test]
391385

392386
asyncpg: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncpg[test]
@@ -400,7 +394,9 @@ commands_pre =
400394

401395
falcon-{1,2,3}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon[test]
402396

403-
flask-{213,220,300}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
397+
flask-0: {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-0
398+
flask-1: {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-1
399+
flask-2: {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/test-2
404400

405401
urllib: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-urllib[test]
406402

@@ -537,7 +533,7 @@ commands_pre =
537533
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-grpc[test]
538534
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon[test]
539535
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-boto[test]
540-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-flask[test]
536+
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-flask
541537
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy[test]
542538
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-cassandra[test]
543539
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-celery[test]

0 commit comments

Comments
 (0)