From bfe25bd0b5f484c4efc23563c5d2965ad6a45f77 Mon Sep 17 00:00:00 2001 From: Jimmi Dyson Date: Tue, 22 Aug 2023 20:19:57 +0100 Subject: [PATCH] fix: Add missing AfterControlPlaneUpgradeLifecycleHandler interface --- internal/runtimehooks/webhooks/server.go | 11 +++++++++++ pkg/handlers/interfaces.go | 7 +++++++ 2 files changed, 18 insertions(+) diff --git a/internal/runtimehooks/webhooks/server.go b/internal/runtimehooks/webhooks/server.go index 6e984e5c5..15595f12f 100644 --- a/internal/runtimehooks/webhooks/server.go +++ b/internal/runtimehooks/webhooks/server.go @@ -116,6 +116,17 @@ func (s *Server) Start(ctx context.Context) error { } } + if t, ok := h.(handlers.AfterControlPlaneUpgradeLifecycleHandler); ok { + if err := webhookServer.AddExtensionHandler(server.ExtensionHandler{ + Hook: runtimehooksv1.AfterControlPlaneUpgrade, + Name: h.Name(), + HandlerFunc: t.AfterControlPlaneUpgrade, + }); err != nil { + setupLog.Error(err, "error adding handler") + return err + } + } + if t, ok := h.(handlers.BeforeClusterDeleteLifecycleHandler); ok { if err := webhookServer.AddExtensionHandler(server.ExtensionHandler{ Hook: runtimehooksv1.BeforeClusterDelete, diff --git a/pkg/handlers/interfaces.go b/pkg/handlers/interfaces.go index 7082bb063..133c68159 100644 --- a/pkg/handlers/interfaces.go +++ b/pkg/handlers/interfaces.go @@ -32,6 +32,13 @@ type BeforeClusterUpgradeLifecycleHandler interface { *runtimehooksv1.BeforeClusterUpgradeResponse, ) } +type AfterControlPlaneUpgradeLifecycleHandler interface { + AfterControlPlaneUpgrade( + context.Context, + *runtimehooksv1.AfterControlPlaneUpgradeRequest, + *runtimehooksv1.AfterControlPlaneUpgradeResponse, + ) +} type BeforeClusterDeleteLifecycleHandler interface { BeforeClusterDelete( context.Context,