Skip to content

Move execution of the unit tests of the mutation handlers to its own packages #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
supershal opened this issue Mar 21, 2024 · 1 comment
Assignees

Comments

@supershal
Copy link
Contributor

Currently all handler patches are running as a single unit test for each provider.
Ex. AWS: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/pkg/handlers/aws/mutation/metapatch_handler_test.go
Docker: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/pkg/handlers/docker/mutation/metapatch_handler_test.go

In addition to running these tests for each provider, we should also run this test from the handler package. For example, the mirror handler related tests should be able to executed from mirror or mirror/test package. https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/tree/main/pkg/handlers/generic/mutation/mirrors/tests

This might create some duplication of execution of the tests but it will be convenient to execute package level tests during development.

@supershal
Copy link
Contributor Author

d2iq-labs#21 and d2iq-labs#23 addresses this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant