We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently all handler patches are running as a single unit test for each provider. Ex. AWS: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/pkg/handlers/aws/mutation/metapatch_handler_test.go Docker: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/pkg/handlers/docker/mutation/metapatch_handler_test.go
In addition to running these tests for each provider, we should also run this test from the handler package. For example, the mirror handler related tests should be able to executed from mirror or mirror/test package. https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/tree/main/pkg/handlers/generic/mutation/mirrors/tests
mirror
mirror/test
This might create some duplication of execution of the tests but it will be convenient to execute package level tests during development.
The text was updated successfully, but these errors were encountered:
d2iq-labs#21 and d2iq-labs#23 addresses this issue
Sorry, something went wrong.
supershal
No branches or pull requests
Currently all handler patches are running as a single unit test for each provider.
Ex. AWS: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/pkg/handlers/aws/mutation/metapatch_handler_test.go
Docker: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/pkg/handlers/docker/mutation/metapatch_handler_test.go
In addition to running these tests for each provider, we should also run this test from the handler package. For example, the mirror handler related tests should be able to executed from
mirror
ormirror/test
package. https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/tree/main/pkg/handlers/generic/mutation/mirrors/testsThis might create some duplication of execution of the tests but it will be convenient to execute package level tests during development.
The text was updated successfully, but these errors were encountered: