fix: Do not require leader election for CAPI hooks server (#150)

jimmidyson · web-flow · commit e437f576d003 · 2023-09-13T21:05:25.000+01:00
This means it will always run even if there are multiple replicas
running. Leader election is only really useful for controllers, not for
webhooks.
diff --git a/common/pkg/server/server.go b/common/pkg/server/server.go
@@ -58,6 +58,12 @@ func (s *ServerOptions) AddFlags(fs *pflag.FlagSet) {
 	)
 }
 
+// NeedLeaderElection implements the LeaderElectionRunnable interface, which indicates
+// the webhook server doesn't need leader election.
+func (*Server) NeedLeaderElection() bool {
+	return false
+}
+
 func (s *Server) Start(ctx context.Context) error {
 	// Creates a logger to be used during the main func.
 	setupLog := ctrl.Log.WithName("runtimehooks")

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,12 @@ func (s ServerOptions) AddFlags(fs pflag.FlagSet) {`
`58`	`58`	`)`
`59`	`59`	`}`
`60`	`60`
	`61`	`+// NeedLeaderElection implements the LeaderElectionRunnable interface, which indicates`
	`62`	`+// the webhook server doesn't need leader election.`
	`63`	`+func (*Server) NeedLeaderElection() bool {`
	`64`	`+ return false`
	`65`	`+}`
	`66`	`+`
`61`	`67`	`func (s *Server) Start(ctx context.Context) error {`
`62`	`68`	`// Creates a logger to be used during the main func.`
`63`	`69`	`setupLog := ctrl.Log.WithName("runtimehooks")`