fix: linter

Author: mhrabovcin

docs/content/http-proxy.md

@@ -40,11 +40,8 @@ spec:
           - http://no-proxy-2.example.com
 ```
 
-The `additionalNo` list will be added to default pre-calculated values that apply on k8s networking.
-
-```
-localhost,127.0.0.1,<POD CIDRS>,<SERVICE CIDRS>,kubernetes,.svc,.svc.cluster,.svc.cluster.local
-```
+The `additionalNo` list will be added to default pre-calculated values that apply on k8s networking
+`localhost,127.0.0.1,<POD CIDRS>,<SERVICE CIDRS>,kubernetes,.svc,.svc.cluster,.svc.cluster.local`.
 
 Applying this configuration will result in new bootstrap files on the `KubeadmControlPlaneTemplate`
 and `KubeadmConfigTemplate`.

pkg/handlers/httpproxy/inject.go

@@ -145,7 +145,8 @@ func (h *httpProxyPatchHandler) detectNoProxy(
 	clusterKey := types.NamespacedName{}
 
 	for _, item := range req.Items {
-		if item.HolderReference.Kind == "Cluster" && item.HolderReference.APIVersion == capiv1.GroupVersion.String() {
+		if item.HolderReference.Kind == "Cluster" &&
+			item.HolderReference.APIVersion == capiv1.GroupVersion.String() {
 			clusterKey.Name = item.HolderReference.Name
 			clusterKey.Namespace = item.HolderReference.Namespace
 		}
@@ -201,7 +202,7 @@ func generateNoProxy(cluster *capiv1.Cluster) []string {
 
 // mapServiceDomain generates NO_PROXY values for service domain to allow use
 // of short service name in cluster.
-// Example: my.custom => [.svc, .svc.my, .svc.my.custom]
+// Example: my.custom => [.svc, .svc.my, .svc.my.custom].
 func mapServiceDomain(serviceDomain, svcName string) []string {
 	mapped := []string{svcName}
 	progress := svcName

pkg/handlers/httpproxy/inject_test.go

@@ -227,6 +227,7 @@ func TestGenerateNoProxy(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(tt *testing.T) {
+			tt.Parallel()
 			g.Expect(generateNoProxy(tc.cluster)).To(Equal(tc.expectedNoProxy))
 		})
 	}

pkg/handlers/httpproxy/systemd_proxy_config_test.go

@@ -18,80 +18,81 @@ func TestGenerateSystemdFiles(t *testing.T) {
 		vars             HTTPProxyVariables
 		noProxy          []string
 		expectedContents string
-	}{{
-		name: "no proxy configuration",
-	}, {
-		name: "all vars set",
-		vars: HTTPProxyVariables{
-			HTTP:  "http://example.com",
-			HTTPS: "https://example.com",
-			AdditionalNO: []string{
-				"https://no-proxy.example.com",
+	}{
+		{
+			name: "no proxy configuration",
+		}, {
+			name: "all vars set",
+			vars: HTTPProxyVariables{
+				HTTP:  "http://example.com",
+				HTTPS: "https://example.com",
+				AdditionalNO: []string{
+					"https://no-proxy.example.com",
+				},
 			},
-		},
-		expectedContents: `[Service]
+			expectedContents: `[Service]
 Environment="HTTP_PROXY=http://example.com"
 Environment="http_proxy=http://example.com"
 Environment="HTTPS_PROXY=https://example.com"
 Environment="https_proxy=https://example.com"
 Environment="NO_PROXY=https://no-proxy.example.com"
 Environment="no_proxy=https://no-proxy.example.com"
 `,
-	}, {
-		name: "http only",
-		vars: HTTPProxyVariables{
-			HTTP: "http://example.com",
-		},
-		expectedContents: `[Service]
+		}, {
+			name: "http only",
+			vars: HTTPProxyVariables{
+				HTTP: "http://example.com",
+			},
+			expectedContents: `[Service]
 Environment="HTTP_PROXY=http://example.com"
 Environment="http_proxy=http://example.com"
 `,
-	}, {
-		name: "https only",
-		vars: HTTPProxyVariables{
-			HTTPS: "https://example.com",
-		},
-		expectedContents: `[Service]
+		}, {
+			name: "https only",
+			vars: HTTPProxyVariables{
+				HTTPS: "https://example.com",
+			},
+			expectedContents: `[Service]
 Environment="HTTPS_PROXY=https://example.com"
 Environment="https_proxy=https://example.com"
 `,
-	}, {
-		name: "no proxy only",
-		vars: HTTPProxyVariables{
-			AdditionalNO: []string{
-				"https://no-proxy.example.com",
+		}, {
+			name: "no proxy only",
+			vars: HTTPProxyVariables{
+				AdditionalNO: []string{
+					"https://no-proxy.example.com",
+				},
 			},
-		},
-		expectedContents: `[Service]
+			expectedContents: `[Service]
 Environment="NO_PROXY=https://no-proxy.example.com"
 Environment="no_proxy=https://no-proxy.example.com"
 `,
-	}, {
-		name: "multiple no proxy only",
-		vars: HTTPProxyVariables{
-			AdditionalNO: []string{
-				"https://no-proxy.example.com",
-				"https://no-proxy-1.example.com",
+		}, {
+			name: "multiple no proxy only",
+			vars: HTTPProxyVariables{
+				AdditionalNO: []string{
+					"https://no-proxy.example.com",
+					"https://no-proxy-1.example.com",
+				},
 			},
-		},
-		expectedContents: `[Service]
+			expectedContents: `[Service]
 Environment="NO_PROXY=https://no-proxy.example.com,https://no-proxy-1.example.com"
 Environment="no_proxy=https://no-proxy.example.com,https://no-proxy-1.example.com"
 `,
-	}, {
-		name: "default no proxy values",
-		vars: HTTPProxyVariables{
-			AdditionalNO: []string{
-				"https://no-proxy.example.com",
-				"https://no-proxy-1.example.com",
+		}, {
+			name: "default no proxy values",
+			vars: HTTPProxyVariables{
+				AdditionalNO: []string{
+					"https://no-proxy.example.com",
+					"https://no-proxy-1.example.com",
+				},
 			},
-		},
-		noProxy: []string{"localhost", "127.0.0.1"},
-		expectedContents: `[Service]
+			noProxy: []string{"localhost", "127.0.0.1"},
+			expectedContents: `[Service]
 Environment="NO_PROXY=localhost,127.0.0.1,https://no-proxy.example.com,https://no-proxy-1.example.com"
 Environment="no_proxy=localhost,127.0.0.1,https://no-proxy.example.com,https://no-proxy-1.example.com"
 `,
-	},
+		},
 	}
 
 	for idx := range tests {