fix: suggestions from review

Author: faiq

charts/cluster-api-runtime-extensions-nutanix/addons/cluster-autoscaler/values-template.yaml

@@ -1,5 +1,5 @@
 ---
-fullnameOverride: "cluster-autoscaler-{{ index .Cluster.Annotations "caren.nutanix.com/cluster-uuid" }}
+fullnameOverride: "cluster-autoscaler-{{ index .Cluster.Annotations "caren.nutanix.com/cluster-uuid" }}"
 
 cloudProvider: clusterapi
 

charts/cluster-api-runtime-extensions-nutanix/templates/cluster-autoscaler/manifests/cluster-autoscaler-configmap.yaml

@@ -211,7 +211,7 @@ data:
               items:
               - key: value
                 path: kubeconfig
-              secretName: '{{ `{{ index .Cluster.Annotations "caren.nutanix.com/cluster-uuid" }}` }}-kubeconfig'
+              secretName: '{{ `{{ .Cluster.Name }}` }}-kubeconfig'
 kind: ConfigMap
 metadata:
   creationTimestamp: null

hack/addons/kustomize/cluster-autoscaler/manifests/helm-values.yaml

@@ -33,7 +33,7 @@ clusterAPIMode: kubeconfig-incluster
 clusterAPIWorkloadKubeconfigPath: /cluster/kubeconfig
 extraVolumeSecrets:
   kubeconfig:
-    name: tmpl-clusteruuid-tmpl-kubeconfig
+    name: tmpl-clustername-tmpl-kubeconfig
     mountPath: /cluster
     readOnly: true
     items:

hack/addons/kustomize/cluster-autoscaler/manifests/values-template.yaml

@@ -1,5 +1,5 @@
 ---
-fullnameOverride: "cluster-autoscaler-{{ index .Cluster.Annotations "caren.nutanix.com/cluster-uuid" }}
+fullnameOverride: "cluster-autoscaler-{{ index .Cluster.Annotations "caren.nutanix.com/cluster-uuid" }}"
 
 cloudProvider: clusterapi
 

hack/addons/update-cluster-autoscaler.sh

@@ -27,7 +27,7 @@ kustomize build --enable-helm "${ASSETS_DIR}" >"${ASSETS_DIR}/${FILE_NAME}"
 
 # this replaces the custom templating used for kustomize to generate the configmap to using the same templating as we do
 # with helm chart proxy
-# transforming tmpl-clustername-tmpl to -- {{ .Cluster.Name }}
+# transforming tmpl-clustername-tmpl to {{ .Cluster.Name }}
 sed -i -e "s/\([a-z-]*\)tmpl-clustername\([^-]*\)-tmpl\([a-z-]*\)/'\1{{ \`{{ .Cluster.Name\2 }}\` }}\3'/g" \
   -e "s/\([a-z-]*\)tmpl-clusteruuid-tmpl\([a-z-]*\)/'\1{{ \`{{ index .Cluster.Annotations \"caren.nutanix.com\/cluster-uuid\" }}\` }}\2'/g" \
   "${ASSETS_DIR}/${FILE_NAME}"