feat: Deploy snapshot-controller as separate addon (#734)

Currently both Nutanix CSI and AWS EBS CSI handlers deploy the
snapshot-controller. Generally the snapshot-controller should be
treated as a separate addon that all compatible CSI providers can
take advantage of.

This commit removes the snapshot-controller from both Nutanix and
AWS EBS CSI, and instead deploys the snapshot-controller separately
so they can both use it as necessary.

Deployment tested manually on AWS via e2e test suite as well as the
automated Docker test suite running in CI.

Depends on #733.

Author: jimmidyson

api/v1alpha1/addon_types.go

@@ -130,6 +130,17 @@ type ClusterAutoscaler struct {
 type GenericCSI struct {
 	// +kubebuilder:validation:Required
 	DefaultStorage DefaultStorage `json:"defaultStorage"`
+
+	// Deploy the CSI snapshot controller and associated CRDs.
+	// +kubebuilder:validation:Optional
+	SnapshotController *SnapshotController `json:"snapshotController,omitempty"`
+}
+
+type SnapshotController struct {
+	// Addon strategy used to deploy the snapshot controller to the workload cluster.
+	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:Enum=ClusterResourceSet;HelmAddon
+	Strategy AddonStrategy `json:"strategy"`
 }
 
 type DefaultStorage struct {

api/v1alpha1/crds/caren.nutanix.com_awsclusterconfigs.yaml

@@ -180,6 +180,18 @@ spec:
                           required:
                             - aws-ebs
                           type: object
+                        snapshotController:
+                          description: Deploy the CSI snapshot controller and associated CRDs.
+                          properties:
+                            strategy:
+                              description: Addon strategy used to deploy the snapshot controller to the workload cluster.
+                              enum:
+                                - ClusterResourceSet
+                                - HelmAddon
+                              type: string
+                          required:
+                            - strategy
+                          type: object
                       required:
                         - defaultStorage
                         - providers

api/v1alpha1/crds/caren.nutanix.com_dockerclusterconfigs.yaml

@@ -180,6 +180,18 @@ spec:
                           required:
                             - local-path
                           type: object
+                        snapshotController:
+                          description: Deploy the CSI snapshot controller and associated CRDs.
+                          properties:
+                            strategy:
+                              description: Addon strategy used to deploy the snapshot controller to the workload cluster.
+                              enum:
+                                - ClusterResourceSet
+                                - HelmAddon
+                              type: string
+                          required:
+                            - strategy
+                          type: object
                       required:
                         - defaultStorage
                         - providers

api/v1alpha1/crds/caren.nutanix.com_nutanixclusterconfigs.yaml

@@ -180,6 +180,18 @@ spec:
                           required:
                             - nutanix
                           type: object
+                        snapshotController:
+                          description: Deploy the CSI snapshot controller and associated CRDs.
+                          properties:
+                            strategy:
+                              description: Addon strategy used to deploy the snapshot controller to the workload cluster.
+                              enum:
+                                - ClusterResourceSet
+                                - HelmAddon
+                              type: string
+                          required:
+                            - strategy
+                          type: object
                       required:
                         - defaultStorage
                         - providers

api/v1alpha1/zz_generated.deepcopy.go

@@ -66,6 +66,8 @@ A Helm chart for cluster-api-runtime-extensions-nutanix
 | hooks.csi.local-path.helmAddonStrategy.defaultValueTemplateConfigMap.name | string | `"default-local-path-csi-helm-values-template"` |  |
 | hooks.csi.nutanix.helmAddonStrategy.defaultValueTemplateConfigMap.create | bool | `true` |  |
 | hooks.csi.nutanix.helmAddonStrategy.defaultValueTemplateConfigMap.name | string | `"default-nutanix-csi-helm-values-template"` |  |
+| hooks.csi.snapshot-controller.helmAddonStrategy.defaultValueTemplateConfigMap.create | bool | `true` |  |
+| hooks.csi.snapshot-controller.helmAddonStrategy.defaultValueTemplateConfigMap.name | string | `"default-snapshot-controller-helm-values-template"` |  |
 | hooks.nfd.crsStrategy.defaultInstallationConfigMap.name | string | `"node-feature-discovery"` |  |
 | hooks.nfd.helmAddonStrategy.defaultValueTemplateConfigMap.create | bool | `true` |  |
 | hooks.nfd.helmAddonStrategy.defaultValueTemplateConfigMap.name | string | `"default-nfd-helm-values-template"` |  |