Skip to content

Commit 7fc7b26

Browse files
committed
refactor: consistently use the same SetOwnerReference function
1 parent 7ee8f09 commit 7fc7b26

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

pkg/handlers/generic/lifecycle/utils/secrets.go

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import (
1111
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1212
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
1313
"sigs.k8s.io/cluster-api/controllers/remote"
14-
"sigs.k8s.io/cluster-api/util"
1514
ctrlclient "sigs.k8s.io/controller-runtime/pkg/client"
15+
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
1616

1717
"github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/common/pkg/k8s/client"
1818
)
@@ -75,15 +75,13 @@ func EnsureOwnerRefForSecret(
7575
return err
7676
}
7777

78-
secret.OwnerReferences = util.EnsureOwnerRef(
79-
secret.OwnerReferences,
80-
metav1.OwnerReference{
81-
APIVersion: clusterv1.GroupVersion.String(),
82-
Kind: cluster.Kind,
83-
UID: cluster.UID,
84-
Name: cluster.Name,
85-
},
86-
)
78+
err = controllerutil.SetOwnerReference(cluster, secret, cl.Scheme())
79+
if err != nil {
80+
return fmt.Errorf(
81+
"failed to set owner reference on Secret: %w",
82+
err,
83+
)
84+
}
8785

8886
err = cl.Update(ctx, secret)
8987
if err != nil {

0 commit comments

Comments
 (0)