Skip to content

Commit 7f32b05

Browse files
authored
refactor: Reduce log verbosity for skipped handlers (#692)
This should reduce noise in logs.
1 parent 9b1bada commit 7f32b05

File tree

7 files changed

+10
-9
lines changed

7 files changed

+10
-9
lines changed

pkg/handlers/generic/lifecycle/ccm/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func (c *CCMHandler) AfterControlPlaneInitialized(
7979
_, err := variables.Get[v1alpha1.CCM](varMap, c.variableName, c.variablePath...)
8080
if err != nil {
8181
if variables.IsNotFoundError(err) {
82-
log.V(4).Info("Skipping CCM handler.")
82+
log.V(5).Info("Skipping CCM handler.")
8383
return
8484
}
8585
log.Error(

pkg/handlers/generic/lifecycle/clusterautoscaler/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ func (n *DefaultClusterAutoscaler) AfterControlPlaneInitialized(
9494
n.variablePath...)
9595
if err != nil {
9696
if variables.IsNotFoundError(err) {
97-
log.Info(
97+
log.V(5).Info(
9898
"Skipping cluster-autoscaler handler, cluster does not specify request cluster-autoscaler addon deployment",
9999
)
100100
return

pkg/handlers/generic/lifecycle/cni/calico/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func (c *CalicoCNI) AfterControlPlaneInitialized(
9191
cniVar, err := variables.Get[v1alpha1.CNI](varMap, c.variableName, c.variablePath...)
9292
if err != nil {
9393
if variables.IsNotFoundError(err) {
94-
log.
94+
log.V(5).
9595
Info(
9696
"Skipping Calico CNI handler, cluster does not specify request CNI addon deployment",
9797
)
@@ -110,7 +110,7 @@ func (c *CalicoCNI) AfterControlPlaneInitialized(
110110
return
111111
}
112112
if cniVar.Provider != v1alpha1.CNIProviderCalico {
113-
log.Info(
113+
log.V(5).Info(
114114
fmt.Sprintf(
115115
"Skipping Calico CNI handler, cluster does not specify %q as value of CNI provider variable",
116116
v1alpha1.CNIProviderCalico,

pkg/handlers/generic/lifecycle/cni/calico/strategy_crs.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func (s crsStrategy) apply(
6565
infraKind := req.Cluster.Spec.InfrastructureRef.Kind
6666
defaultInstallationConfigMapName, ok := s.config.defaultProviderInstallationConfigMapNames[infraKind]
6767
if !ok {
68-
log.V(4).Info(
68+
log.Info(
6969
fmt.Sprintf(
7070
"Skipping Calico CNI handler, no default installation ConfigMap configured for infrastructure provider %q",
7171
req.Cluster.Spec.InfrastructureRef.Kind,

pkg/handlers/generic/lifecycle/cni/cilium/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func (c *CiliumCNI) AfterControlPlaneInitialized(
9191
cniVar, err := variables.Get[v1alpha1.CNI](varMap, c.variableName, c.variablePath...)
9292
if err != nil {
9393
if variables.IsNotFoundError(err) {
94-
log.
94+
log.V(5).
9595
Info(
9696
"Skipping Cilium CNI handler, cluster does not specify request CNI addon deployment",
9797
)
@@ -110,7 +110,7 @@ func (c *CiliumCNI) AfterControlPlaneInitialized(
110110
return
111111
}
112112
if cniVar.Provider != v1alpha1.CNIProviderCilium {
113-
log.Info(
113+
log.V(5).Info(
114114
fmt.Sprintf(
115115
"Skipping Cilium CNI handler, cluster does not specify %q as value of CNI provider variable",
116116
v1alpha1.CNIProviderCilium,

pkg/handlers/generic/lifecycle/nfd/handler.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ func (n *DefaultNFD) AfterControlPlaneInitialized(
9191
cniVar, err := variables.Get[v1alpha1.NFD](varMap, n.variableName, n.variablePath...)
9292
if err != nil {
9393
if variables.IsNotFoundError(err) {
94-
log.Info("Skipping NFD handler, cluster does not specify request NFDaddon deployment")
94+
log.V(5).
95+
Info("Skipping NFD handler, cluster does not specify request NFDaddon deployment")
9596
return
9697
}
9798
log.Error(

pkg/handlers/generic/lifecycle/serviceloadbalancer/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ func (c *ServiceLoadBalancerHandler) AfterControlPlaneInitialized(
7474
c.variablePath...)
7575
if err != nil {
7676
if variables.IsNotFoundError(err) {
77-
log.
77+
log.V(5).
7878
Info(
7979
"Skipping ServiceLoadBalancer, field is not specified",
8080
"error",

0 commit comments

Comments
 (0)