Skip to content

Commit 7ccc23b

Browse files
authored
test: Remove hard-coded text focus and label for e2e tests (#667)
**What problem does this PR solve?**: Removes hard-coded text focus and label for e2e tests. This code took precedent over any configuration provided to ginkgo at runtime, so only single e2e test matching both focus and labels could run. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> I used dry-run (added in #666) to confirm that the removed code was the root cause.
1 parent a51e8db commit 7ccc23b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

test/e2e/e2e_suite_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ func TestE2E(t *testing.T) {
7777
ctrl.SetLogger(klog.Background())
7878
RegisterFailHandler(Fail)
7979
suiteConfig, reporterConfig := GinkgoConfiguration()
80-
suiteConfig.LabelFilter = "provider:Docker && cni:Cilium && addonStrategy:ClusterResourceSet"
81-
suiteConfig.FocusStrings = []string{"Quick start"}
8280
RunSpecs(t, "caren-e2e", suiteConfig, reporterConfig)
8381
}
8482

0 commit comments

Comments
 (0)