Skip to content

Commit 76c7c6f

Browse files
authored
build: Fix an incorrect make variable passed to goreleaser (#716)
**What problem does this PR solve?**: The make variable reference was replaced recently in https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/704/files#diff-fa98b7f1d4a049ad777fb9453f6657c512c8b715a9f8bc47dfd57f1143bbb930L14. The new reference is to `GORELEASE_VERBOSE`, which is unset, and goreleaser fails: ```shell > make build-snapshot ▶ running go generate make[1]: Entering directory '/home/dlipovetsky/nutanix/capi-runtime-extensions' ▶ configuring supported csi providers make[1]: Leaving directory '/home/dlipovetsky/nutanix/capi-runtime-extensions' ▶ building snapshot ⨯ command failed error=invalid argument "" for "--verbose" flag: strconv.ParseBool: parsing "": invalid syntax ``` Not sure how CI passed for #704, because this issue affects main. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
1 parent 6a23695 commit 76c7c6f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

make/goreleaser.mk

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# SPDX-License-Identifier: Apache-2.0
33

44
GORELEASER_PARALLELISM ?= $(shell nproc --ignore=1)
5-
GORELEASER_DEBUG ?= false
5+
GORELEASER_VERBOSE ?= false
66

77
ifndef GORELEASER_CURRENT_TAG
88
export GORELEASER_CURRENT_TAG=$(GIT_TAG)
@@ -21,7 +21,7 @@ build-snapshot: go-generate ; $(info $(M) building snapshot $*)
2121
.PHONY: release
2222
release: ## Builds a release with goreleaser
2323
release: go-generate ; $(info $(M) building release $*)
24-
goreleaser --verbose=$(GORELEASER_DEBUG) \
24+
goreleaser --verbose=$(GORELEASER_VERBOSE) \
2525
release \
2626
--clean \
2727
--parallelism=$(GORELEASER_PARALLELISM) \
@@ -31,7 +31,7 @@ release: go-generate ; $(info $(M) building release $*)
3131
.PHONY: release-snapshot
3232
release-snapshot: ## Builds a snapshot release with goreleaser
3333
release-snapshot: go-generate ; $(info $(M) building snapshot release $*)
34-
goreleaser --verbose=$(GORELEASER_DEBUG) \
34+
goreleaser --verbose=$(GORELEASER_VERBOSE) \
3535
release \
3636
--snapshot \
3737
--clean \

0 commit comments

Comments
 (0)