Skip to content

Commit 7297882

Browse files
authored
fix: Add missing AfterControlPlaneUpgradeLifecycleHandler interface (#113)
1 parent ba830d7 commit 7297882

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

internal/runtimehooks/webhooks/server.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,17 @@ func (s *Server) Start(ctx context.Context) error {
116116
}
117117
}
118118

119+
if t, ok := h.(handlers.AfterControlPlaneUpgradeLifecycleHandler); ok {
120+
if err := webhookServer.AddExtensionHandler(server.ExtensionHandler{
121+
Hook: runtimehooksv1.AfterControlPlaneUpgrade,
122+
Name: h.Name(),
123+
HandlerFunc: t.AfterControlPlaneUpgrade,
124+
}); err != nil {
125+
setupLog.Error(err, "error adding handler")
126+
return err
127+
}
128+
}
129+
119130
if t, ok := h.(handlers.BeforeClusterDeleteLifecycleHandler); ok {
120131
if err := webhookServer.AddExtensionHandler(server.ExtensionHandler{
121132
Hook: runtimehooksv1.BeforeClusterDelete,

pkg/handlers/interfaces.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@ type BeforeClusterUpgradeLifecycleHandler interface {
3232
*runtimehooksv1.BeforeClusterUpgradeResponse,
3333
)
3434
}
35+
type AfterControlPlaneUpgradeLifecycleHandler interface {
36+
AfterControlPlaneUpgrade(
37+
context.Context,
38+
*runtimehooksv1.AfterControlPlaneUpgradeRequest,
39+
*runtimehooksv1.AfterControlPlaneUpgradeResponse,
40+
)
41+
}
3542
type BeforeClusterDeleteLifecycleHandler interface {
3643
BeforeClusterDelete(
3744
context.Context,

0 commit comments

Comments
 (0)