fixup! ci: Add actionlint to pre-commit and workflow

Author: jimmidyson

.github/workflows/checks.yml

@@ -87,7 +87,7 @@ jobs:
         if: always()
         run: make kind.delete
 
-  lint:
+  lint-go:
     runs-on: ubuntu-22.04
     steps:
       - name: Check out code
@@ -111,8 +111,8 @@ jobs:
       - name: Export golang and golangci-lint versions
         id: versions
         run: |
-          echo "golangci-lint=$(devbox run -- golangci-lint version --format short)" >>$GITHUB_OUTPUT
-          echo "golang=$(devbox run -- go version | grep -o "[[:digit:]]\+.[[:digit:]]\+\(.[[:digit:]]\+\)\?")" >>$GITHUB_OUTPUT
+          echo "golangci-lint=$(devbox run -- golangci-lint version --format short)" >>"${GITHUB_OUTPUT}"
+          echo "golang=$(devbox run -- go version | grep -o "[[:digit:]]\+.[[:digit:]]\+\(.[[:digit:]]\+\)\?")" >>"${GITHUB_OUTPUT}"
 
       - name: golangci-lint
         uses: reviewdog/action-golangci-lint@v2
@@ -122,6 +122,18 @@ jobs:
           golangci_lint_version: v${{ steps.versions.outputs.golangci-lint }}
           go_version: v${{ steps.versions.outputs.golang }}
 
+  lint-gha:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v3
+
+      - name: actionlint
+        uses: reviewdog/action-actionlint@v1
+        with:
+          fail_on_error: true
+          reporter: github-pr-review
+
   pre-commit:
     runs-on: ubuntu-22.04
     steps:
@@ -152,7 +164,7 @@ jobs:
       - name: Run pre-commit
         run: devbox run -- make pre-commit
         env:
-          SKIP: no-commit-to-branch,golangci-lint
+          SKIP: no-commit-to-branch,golangci-lint,actionlint-system
 
   lint-test-helm:
     runs-on: ubuntu-22.04
@@ -193,7 +205,7 @@ jobs:
         name: Create kind cluster
         run: |
           devbox run -- kind create cluster \
-            --image=ghcr.io/mesosphere/kind-node:$(kubectl version --output=json --client | gojq --raw-output .clientVersion.gitVersion) \
+            --image=ghcr.io/mesosphere/kind-node:"$(kubectl version --output=json --client | gojq --raw-output .clientVersion.gitVersion)" \
             --name=chart-testing
         env:
           KUBECONFIG: ct-kind-kubeconfig

.github/workflows/recover-secret.yaml

@@ -41,6 +41,11 @@ repos:
     stages: [commit]
   - id: end-of-file-fixer
     stages: [commit]
+- repo: https://github.com/rhysd/actionlint
+  rev: v1.6.25
+  hooks:
+  - id: actionlint-system
+    stages: [commit]
 - repo: https://github.com/jorisroovers/gitlint
   rev: v0.19.1
   hooks:

.pre-commit-config.yaml

@@ -24,7 +24,8 @@
     "gotestsum@latest",
     "golines@latest",
     "envsubst@latest",
-    "kubernetes-controller-tools@latest"
+    "kubernetes-controller-tools@latest",
+    "actionlint@latest"
   ],
   "shell": {
     "init_hook": [

devbox.json

@@ -1,6 +1,12 @@
 {
   "lockfile_version": "1",
   "packages": {
+    "actionlint@latest": {
+      "last_modified": "2023-06-30T04:44:22Z",
+      "resolved": "github:NixOS/nixpkgs/3c614fbc76fc152f3e1bc4b2263da6d90adf80fb#actionlint",
+      "source": "devbox-search",
+      "version": "1.6.25"
+    },
     "chart-testing@latest": {
       "last_modified": "2023-07-23T03:35:12Z",
       "resolved": "github:NixOS/nixpkgs/af8cd5ded7735ca1df1a1174864daab75feeb64a#chart-testing",