Skip to content

Commit 3ff2e54

Browse files
authored
fix: Upgrade dynamic-credential-provider to v0.5.3 (#677)
Fixes falling back to origin registry if mirror does not contain requested image.
1 parent 0d3f527 commit 3ff2e54

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

pkg/handlers/generic/mutation/imageregistries/credentials/credential_provider_config_files_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ credentialProviders:
267267
kind: DynamicCredentialProviderConfig
268268
mirror:
269269
endpoint: 98765432.dkr.ecr.us-east-1.amazonaws.com
270-
credentialsStrategy: MirrorCredentialsOnly
270+
credentialsStrategy: MirrorCredentialsFirst
271271
credentialProviderPluginBinDir: /etc/kubernetes/image-credential-provider/
272272
credentialProviders:
273273
apiVersion: kubelet.config.k8s.io/v1
@@ -315,7 +315,7 @@ credentialProviders:
315315
kind: DynamicCredentialProviderConfig
316316
mirror:
317317
endpoint: mymirror.com
318-
credentialsStrategy: MirrorCredentialsOnly
318+
credentialsStrategy: MirrorCredentialsFirst
319319
credentialProviderPluginBinDir: /etc/kubernetes/image-credential-provider/
320320
credentialProviders:
321321
apiVersion: kubelet.config.k8s.io/v1

pkg/handlers/generic/mutation/imageregistries/credentials/credential_provider_install_files.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var (
2323

2424
const (
2525
//nolint:gosec // Does not contain hard coded credentials.
26-
dynamicCredentialProviderImage = "ghcr.io/mesosphere/dynamic-credential-provider:v0.5.0"
26+
dynamicCredentialProviderImage = "ghcr.io/mesosphere/dynamic-credential-provider:v0.5.3"
2727

2828
//nolint:gosec // Does not contain hard coded credentials.
2929
credentialProviderTargetDir = "/etc/kubernetes/image-credential-provider/"

pkg/handlers/generic/mutation/imageregistries/credentials/templates/dynamic-credential-provider-config.yaml.gotmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ kind: DynamicCredentialProviderConfig
44
{{- if .Mirror }}
55
mirror:
66
endpoint: {{ .RegistryHost }}
7-
credentialsStrategy: MirrorCredentialsOnly
7+
credentialsStrategy: MirrorCredentialsFirst
88
{{- break }}
99
{{- end }}
1010
{{- end }}

0 commit comments

Comments
 (0)