fix: do not error out if control plane endpoint is hostname

Author: manoj-nutanix

pkg/webhook/cluster/nutanix_validator.go

@@ -153,9 +153,9 @@ func checkIfPrismCentralAndControlPlaneIPSame(
 		controlPlaneEndpointSpec.ControlPlaneEndpointIP(),
 	)
 	if err != nil {
-		// controlPlaneEndpointIP is strictly accepted as an IP address from user so
-		// if it is not an IP address, it is invalid.
-		return fmt.Errorf("invalid Nutanix control plane endpoint IP: %w", err)
+		// If controlPlaneEndpointIP is a hostname, we cannot compare it with PC IP
+		// so return directly.
+		return nil
 	}
 
 	pcHostname, _, err := pcEndpoint.ParseURL()

pkg/webhook/cluster/nutanix_validator_test.go

@@ -144,17 +144,14 @@ func TestCheckIfPrismCentralAndControlPlaneIPSame(t *testing.T) {
 			),
 		},
 		{
-			name: "Invalid Control Plane IP",
+			name: "Control Plane IP specified as hostname",
 			pcEndpoint: v1alpha1.NutanixPrismCentralEndpointSpec{
 				URL: "https://192.168.1.1:9440",
 			},
 			controlPlaneEndpointSpec: v1alpha1.ControlPlaneEndpointSpec{
-				Host: "invalid-ip",
+				Host: "dummy-hostname",
 			},
-			expectedErr: fmt.Errorf(
-				"invalid Nutanix control plane endpoint IP: ParseAddr(%q): unable to parse IP",
-				"invalid-ip",
-			),
+			expectedErr: nil,
 		},
 		{
 			name: "Invalid Prism Central URL",
@@ -199,7 +196,7 @@ func TestCheckIfPrismCentralAndControlPlaneIPSame(t *testing.T) {
 			),
 		},
 		{
-			name: "With KubeVIP ovveride and different PC and Control Plane IPs",
+			name: "With KubeVIP override and different PC and Control Plane IPs",
 			pcEndpoint: v1alpha1.NutanixPrismCentralEndpointSpec{
 				URL: "https://192.168.1.2:9440",
 			},