fixup! refactor: Apply review feedback

Author: jimmidyson

charts/capi-runtime-extensions/templates/deployment.yaml

@@ -39,6 +39,7 @@ spec:
         - --nfd.helm-addon.default-values-template-configmap-name={{ .Values.hooks.nfd.helmAddonStrategy.defaultValueTemplateConfigMap.name }}
         - --awscpi.defaults-namespace={{ .Release.Namespace }}
         - --awsebs.defaults-namespace={{ .Release.Namespace }}
+        - --cluster-autoscaler.crs.defaults-namespace={{ .Release.Namespace }}
         {{- range $key, $value := .Values.extraArgs }}
         - --{{ $key }}={{ $value }}
         {{- end }}

docs/content/addons/cluster-autoscaler.md

@@ -7,7 +7,7 @@ on the new cluster via `ClusterResourceSets` at the `AfterControlPlaneInitialize
 
 Deployment of Cluster Autoscaler is opt-in via the  [provider-specific cluster configuration]({{< ref ".." >}}).
 
-The hook creates a `ClusterResourceSet` to deploy the NFD resources.
+The hook creates a `ClusterResourceSet` to deploy the Cluster Autoscaler resources.
 
 ## Example
 
@@ -36,7 +36,7 @@ spec:
               cluster.x-k8s.io/cluster-api-autoscaler-node-group-max-size: "3"
               cluster.x-k8s.io/cluster-api-autoscaler-node-group-min-size: "1"
           name: md-0
-          # Remove the replicas field, otherwise the topology controller will revert back the aytoscaler's changes
+          # Remove the replicas field, otherwise the topology controller will revert back the autoscaler's changes
 ```
 
 [cluster-autoscaler]: https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider/clusterapi

hack/examples/sync.sh

@@ -108,4 +108,4 @@ sed -i'' 's/cloud-provider:\ aws/cloud-provider:\ external/g' "${EXAMPLE_CLUSTER
 
 # TODO Remove once kustomize supports retaining quotes in what will be numeric values.
 #shellcheck disable=SC2016
-sed -i'' 's/size\: ${WORKER_MACHINE_COUNT}/size\: "${WORKER_MACHINE_COUNT}"/' "${EXAMPLE_CLUSTERS_DIR}"/*.yaml
+sed -i'' 's/\( cluster.x-k8s.io\/cluster-api-autoscaler-node-group-\(min\|max\)-size\): \(${WORKER_MACHINE_COUNT}\)/\1: "\3"/' "${EXAMPLE_CLUSTERS_DIR}"/*.yaml

pkg/handlers/generic/lifecycle/handlers.go

@@ -61,7 +61,7 @@ func (h *Handlers) AllHandlers(mgr manager.Manager) []handlers.Named {
 
 func (h *Handlers) AddFlags(flagSet *pflag.FlagSet) {
 	h.nfdConfig.AddFlags("nfd", flagSet)
-	h.clusterAutoscalerConfig.AddFlags("clusterAutoscaler", flagSet)
+	h.clusterAutoscalerConfig.AddFlags("cluster-autoscaler", flagSet)
 	h.calicoCNIConfig.AddFlags("cni.calico", flagSet)
 	h.ciliumCNIConfig.AddFlags("cni.cilium", flagSet)
 	h.ebsConfig.AddFlags("awsebs", pflag.CommandLine)