Skip to content

Commit 13523f9

Browse files
faiqfaiq
committed
fix: issues with mindthegap deplotment (#660)
**What problem does this PR solve?**: This adds trust-manager to allow us to use self hosted helm charts in mindthegap. See: kubernetes-sigs/cluster-api-addon-provider-helm#104 We can think about this in a couple of different parts: 1. Installing trust-manager and CRDs. We need to install trust manager so that we can create a certificate bundle with our self signed cert to caaph-controller-manager. We pull the CRDs separately because we are unable to use them in our templates because they aren't available at that time. See the comment in the script for more details. 2. Modifying CAAPH to use the bundle. This is done through a job it has a corresponding Service Account/Role/Role Binding. 3. Various little fixes. ie changing repository url and versions to using `v` I tested this by creating a docker cluster. The helm chart proxies use this value ```yaml - apiVersion: addons.cluster.x-k8s.io/v1alpha1 kind: HelmChartProxy metadata: creationTimestamp: "2024-05-14T23:41:09Z" finalizers: - helmchartproxy.addons.cluster.x-k8s.io generation: 1 name: node-feature-discovery-docker-cluster-cilium-helm-addon namespace: default ownerReferences: - apiVersion: cluster.x-k8s.io/v1beta1 kind: Cluster name: docker-cluster-cilium-helm-addon uid: e0e943e4-6d63-4d85-8d37-f63160ff93e3 resourceVersion: "3282" uid: e04b6b62-5f39-4528-87f7-5928d2afd4dd spec: chartName: node-feature-discovery clusterSelector: matchLabels: cluster.x-k8s.io/cluster-name: docker-cluster-cilium-helm-addon namespace: node-feature-discovery options: enableClientCache: false install: createNamespace: true timeout: 10m0s upgrade: maxHistory: 10 releaseName: node-feature-discovery repoURL: oci://mindthegap.mindthegap.svc/charts ``` **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
1 parent f23fa9d commit 13523f9

File tree

9 files changed

+71
-70
lines changed

9 files changed

+71
-70
lines changed

‎charts/cluster-api-runtime-extensions-nutanix/templates/helm-config.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,39 +10,39 @@ data:
1010
cilium: |
1111
ChartName: cilium
1212
ChartVersion: 1.15.0
13-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
13+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
1414
cluster-autoscaler: |
1515
ChartName: cluster-autoscaler
1616
ChartVersion: 9.37.0
17-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
17+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
1818
local-path-provisioner-csi: |
1919
ChartName: local-path-provisioner
2020
ChartVersion: v0.0.29
2121
RepositoryURL: https://charts.containeroo.ch
2222
metallb: |
2323
ChartName: metallb
2424
ChartVersion: v0.14.5
25-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
25+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
2626
nfd: |
2727
ChartName: node-feature-discovery
28-
ChartVersion: v0.15.2
29-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
28+
ChartVersion: 0.15.2
29+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
3030
nutanix-ccm: |
3131
ChartName: nutanix-cloud-provider
3232
ChartVersion: 0.3.3
33-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
33+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
3434
nutanix-snapshot-csi: |
3535
ChartName: nutanix-csi-snapshot
3636
ChartVersion: 6.3.2
37-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
37+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
3838
nutanix-storage-csi: |
3939
ChartName: nutanix-csi-storage
40-
ChartVersion: v3.0.0-beta.1912
41-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
40+
ChartVersion: 3.0.0-beta.1912
41+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
4242
tigera-operator: |
4343
ChartName: tigera-operator
4444
ChartVersion: v3.28.0
45-
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc
45+
RepositoryURL: oci://mindthegap.{{ .Release.Namespace }}.svc/charts
4646
kind: ConfigMap
4747
metadata:
4848
creationTimestamp: null

‎charts/cluster-api-runtime-extensions-nutanix/templates/helm-chart-svc.yaml renamed to ‎charts/cluster-api-runtime-extensions-nutanix/templates/mindthegap.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
# Copyright 2023 D2iQ, Inc. All rights reserved.
1+
# Copyright 2024 Nutanix. All rights reserved.
22
# SPDX-License-Identifier: Apache-2.0
3-
3+
# This file contains the manifests to run a mindthegap deployment which contains helm charts for our addons.
4+
# The pod is built via goreleaser with configuration from hack/addons.
5+
#
46
apiVersion: cert-manager.io/v1
57
kind: Issuer
68
metadata:
@@ -12,12 +14,12 @@ spec:
1214
apiVersion: cert-manager.io/v1
1315
kind: Certificate
1416
metadata:
15-
name: mindthegap-example-tls
17+
name: mindthegap-tls
1618
namespace: {{ .Release.Namespace }}
1719
spec:
1820
dnsNames:
19-
- mindthegap.default.svc
20-
- mindthegap.default.svc.cluster.local
21+
- mindthegap.{{ .Release.Namespace }}.svc
22+
- mindthegap.{{ .Release.Namespace }}.svc.cluster.local
2123
issuerRef:
2224
name: mindthegap-selfsigned
2325
kind: Issuer

‎devbox.lock

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@
9898
}
9999
},
100100
"coreutils@latest": {
101-
"last_modified": "2024-05-22T06:18:38Z",
102-
"resolved": "github:NixOS/nixpkgs/3f316d2a50699a78afe5e77ca486ad553169061e#coreutils",
101+
"last_modified": "2024-06-09T00:38:05Z",
102+
"resolved": "github:NixOS/nixpkgs/3bcedce9f4de37570242faf16e1e143583407eab#coreutils",
103103
"source": "devbox-search",
104104
"version": "9.5",
105105
"systems": {
@@ -156,13 +156,13 @@
156156
"path": "/nix/store/php4qidg2bxzmm79vpri025bqi0fa889-coreutils-9.5",
157157
"default": true
158158
},
159-
{
160-
"name": "info",
161-
"path": "/nix/store/xp1fkjjkw9l63815ll6mzwbjm0jqjwkl-coreutils-9.5-info"
162-
},
163159
{
164160
"name": "debug",
165161
"path": "/nix/store/8slafzx35rrfhzqwzqv3nb2nnbwq1630-coreutils-9.5-debug"
162+
},
163+
{
164+
"name": "info",
165+
"path": "/nix/store/xp1fkjjkw9l63815ll6mzwbjm0jqjwkl-coreutils-9.5-info"
166166
}
167167
],
168168
"store_path": "/nix/store/php4qidg2bxzmm79vpri025bqi0fa889-coreutils-9.5"
@@ -218,8 +218,8 @@
218218
}
219219
},
220220
"findutils@latest": {
221-
"last_modified": "2024-05-30T12:09:21Z",
222-
"resolved": "github:NixOS/nixpkgs/aa61b27554a5fc282758bf0324781e3464ef2cde#findutils",
221+
"last_modified": "2024-06-04T00:03:09Z",
222+
"resolved": "github:NixOS/nixpkgs/3b01abcc24846ae49957b30f4345bab4b3f1d14b#findutils",
223223
"source": "devbox-search",
224224
"version": "4.9.0",
225225
"systems": {
@@ -230,13 +230,13 @@
230230
"path": "/nix/store/v2f2czixsg2vqjck84n879whz8bc1zg5-findutils-4.9.0",
231231
"default": true
232232
},
233-
{
234-
"name": "info",
235-
"path": "/nix/store/kp3pv46r60zflkz2kbpk26nv6rka5wsr-findutils-4.9.0-info"
236-
},
237233
{
238234
"name": "locate",
239235
"path": "/nix/store/zai9zalsmh0fc052x3grch9g0k27i4br-findutils-4.9.0-locate"
236+
},
237+
{
238+
"name": "info",
239+
"path": "/nix/store/kp3pv46r60zflkz2kbpk26nv6rka5wsr-findutils-4.9.0-info"
240240
}
241241
],
242242
"store_path": "/nix/store/v2f2czixsg2vqjck84n879whz8bc1zg5-findutils-4.9.0"
@@ -394,8 +394,8 @@
394394
}
395395
},
396396
"git@latest": {
397-
"last_modified": "2024-05-22T06:18:38Z",
398-
"resolved": "github:NixOS/nixpkgs/3f316d2a50699a78afe5e77ca486ad553169061e#git",
397+
"last_modified": "2024-06-04T00:03:09Z",
398+
"resolved": "github:NixOS/nixpkgs/3b01abcc24846ae49957b30f4345bab4b3f1d14b#git",
399399
"source": "devbox-search",
400400
"version": "2.44.1",
401401
"systems": {
@@ -466,8 +466,8 @@
466466
}
467467
},
468468
"gnumake@latest": {
469-
"last_modified": "2024-05-22T06:18:38Z",
470-
"resolved": "github:NixOS/nixpkgs/3f316d2a50699a78afe5e77ca486ad553169061e#gnumake",
469+
"last_modified": "2024-06-04T00:03:09Z",
470+
"resolved": "github:NixOS/nixpkgs/3b01abcc24846ae49957b30f4345bab4b3f1d14b#gnumake",
471471
"source": "devbox-search",
472472
"version": "4.4.1",
473473
"systems": {
@@ -862,50 +862,50 @@
862862
}
863863
},
864864
"govulncheck@latest": {
865-
"last_modified": "2024-05-29T10:04:41Z",
866-
"resolved": "github:NixOS/nixpkgs/ac82a513e55582291805d6f09d35b6d8b60637a1#govulncheck",
865+
"last_modified": "2024-06-07T15:28:25Z",
866+
"resolved": "github:NixOS/nixpkgs/d226935fd75012939397c83f6c385e4d6d832288#govulncheck",
867867
"source": "devbox-search",
868-
"version": "1.1.1",
868+
"version": "1.1.2",
869869
"systems": {
870870
"aarch64-darwin": {
871871
"outputs": [
872872
{
873873
"name": "out",
874-
"path": "/nix/store/p7yy5vcwxdwk1yxjc7ki024yh615w73h-govulncheck-1.1.1",
874+
"path": "/nix/store/3iyrx1iwmrr5ggl9gj964zbswzwbqp6m-govulncheck-1.1.2",
875875
"default": true
876876
}
877877
],
878-
"store_path": "/nix/store/p7yy5vcwxdwk1yxjc7ki024yh615w73h-govulncheck-1.1.1"
878+
"store_path": "/nix/store/3iyrx1iwmrr5ggl9gj964zbswzwbqp6m-govulncheck-1.1.2"
879879
},
880880
"aarch64-linux": {
881881
"outputs": [
882882
{
883883
"name": "out",
884-
"path": "/nix/store/v2jxc5slkbbfcfpqwr959cfvp1fasz6h-govulncheck-1.1.1",
884+
"path": "/nix/store/02gz1gyz01b890s8r52c9vmaf0k1p2cs-govulncheck-1.1.2",
885885
"default": true
886886
}
887887
],
888-
"store_path": "/nix/store/v2jxc5slkbbfcfpqwr959cfvp1fasz6h-govulncheck-1.1.1"
888+
"store_path": "/nix/store/02gz1gyz01b890s8r52c9vmaf0k1p2cs-govulncheck-1.1.2"
889889
},
890890
"x86_64-darwin": {
891891
"outputs": [
892892
{
893893
"name": "out",
894-
"path": "/nix/store/s4fi5h5dld3vc4zj45pcahy2yscnp8ph-govulncheck-1.1.1",
894+
"path": "/nix/store/21l0mpphg07hhaxzqa328gfj3v4f6b2g-govulncheck-1.1.2",
895895
"default": true
896896
}
897897
],
898-
"store_path": "/nix/store/s4fi5h5dld3vc4zj45pcahy2yscnp8ph-govulncheck-1.1.1"
898+
"store_path": "/nix/store/21l0mpphg07hhaxzqa328gfj3v4f6b2g-govulncheck-1.1.2"
899899
},
900900
"x86_64-linux": {
901901
"outputs": [
902902
{
903903
"name": "out",
904-
"path": "/nix/store/5f9fb3w0qk7l7sh062i8rdhzyz5nhkan-govulncheck-1.1.1",
904+
"path": "/nix/store/wfs0ga9di8kamsh0860qjaqs16hz4zmq-govulncheck-1.1.2",
905905
"default": true
906906
}
907907
],
908-
"store_path": "/nix/store/5f9fb3w0qk7l7sh062i8rdhzyz5nhkan-govulncheck-1.1.1"
908+
"store_path": "/nix/store/wfs0ga9di8kamsh0860qjaqs16hz4zmq-govulncheck-1.1.2"
909909
}
910910
}
911911
},
@@ -1282,8 +1282,8 @@
12821282
}
12831283
},
12841284
"kustomize@latest": {
1285-
"last_modified": "2024-06-06T04:00:50Z",
1286-
"resolved": "github:NixOS/nixpkgs/818dbe2f96df233d2041739d6079bb616d3e5597#kustomize",
1285+
"last_modified": "2024-06-08T17:34:36Z",
1286+
"resolved": "github:NixOS/nixpkgs/cd18e2ae9ab8e2a0a8d715b60c91b54c0ac35ff9#kustomize",
12871287
"source": "devbox-search",
12881288
"version": "5.4.2",
12891289
"systems": {
@@ -1330,52 +1330,52 @@
13301330
}
13311331
},
13321332
"pre-commit@latest": {
1333-
"last_modified": "2024-06-04T00:03:09Z",
1334-
"resolved": "github:NixOS/nixpkgs/3b01abcc24846ae49957b30f4345bab4b3f1d14b#pre-commit",
1333+
"last_modified": "2024-06-06T04:00:50Z",
1334+
"resolved": "github:NixOS/nixpkgs/818dbe2f96df233d2041739d6079bb616d3e5597#pre-commit",
13351335
"source": "devbox-search",
13361336
"version": "3.7.1",
13371337
"systems": {
13381338
"aarch64-darwin": {
13391339
"outputs": [
13401340
{
13411341
"name": "out",
1342-
"path": "/nix/store/0z03a4cpv2jshqlms3727iwqc715j4vf-pre-commit-3.7.1",
1342+
"path": "/nix/store/pxd2jrn0hk62jc68r34rnvwha8v03n2v-pre-commit-3.7.1",
13431343
"default": true
13441344
},
13451345
{
13461346
"name": "dist",
1347-
"path": "/nix/store/1pkf93j2mad19l57pkdrs8nifsjzdmhy-pre-commit-3.7.1-dist"
1347+
"path": "/nix/store/17cs6hywf9i7xcshyz1qhm5g5ic24qs1-pre-commit-3.7.1-dist"
13481348
}
13491349
],
1350-
"store_path": "/nix/store/0z03a4cpv2jshqlms3727iwqc715j4vf-pre-commit-3.7.1"
1350+
"store_path": "/nix/store/pxd2jrn0hk62jc68r34rnvwha8v03n2v-pre-commit-3.7.1"
13511351
},
13521352
"aarch64-linux": {
13531353
"outputs": [
13541354
{
13551355
"name": "out",
1356-
"path": "/nix/store/csf42gw742isqh5m2j6zz89chkjr6dr9-pre-commit-3.7.1",
1356+
"path": "/nix/store/g42v1discdsllvnx3q9k1ar2z59n4ymw-pre-commit-3.7.1",
13571357
"default": true
13581358
},
13591359
{
13601360
"name": "dist",
1361-
"path": "/nix/store/cpwj3gkdglf8y8c56982yl0mg1lg81g2-pre-commit-3.7.1-dist"
1361+
"path": "/nix/store/xqm3swfzp22502nmjpzqf6pnqb39y9k9-pre-commit-3.7.1-dist"
13621362
}
13631363
],
1364-
"store_path": "/nix/store/csf42gw742isqh5m2j6zz89chkjr6dr9-pre-commit-3.7.1"
1364+
"store_path": "/nix/store/g42v1discdsllvnx3q9k1ar2z59n4ymw-pre-commit-3.7.1"
13651365
},
13661366
"x86_64-darwin": {
13671367
"outputs": [
13681368
{
13691369
"name": "out",
1370-
"path": "/nix/store/wxvq4rnbh0bl047v5jnqq9scvppnfg8x-pre-commit-3.7.1",
1370+
"path": "/nix/store/yi6f9fm26zacl6ww5dfslliclqldz2s1-pre-commit-3.7.1",
13711371
"default": true
13721372
},
13731373
{
13741374
"name": "dist",
1375-
"path": "/nix/store/qf0icrlw7n3l2pdq2dw3nx0mdb5pfn5s-pre-commit-3.7.1-dist"
1375+
"path": "/nix/store/2ziiyvmn9sf9sw9k407w5ibbw259jsyx-pre-commit-3.7.1-dist"
13761376
}
13771377
],
1378-
"store_path": "/nix/store/wxvq4rnbh0bl047v5jnqq9scvppnfg8x-pre-commit-3.7.1"
1378+
"store_path": "/nix/store/yi6f9fm26zacl6ww5dfslliclqldz2s1-pre-commit-3.7.1"
13791379
},
13801380
"x86_64-linux": {
13811381
"outputs": [

‎hack/addons/kustomize/nfd/kustomization.yaml.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ helmCharts:
1818
valuesFile: helm-values.yaml
1919
valuesInline:
2020
image:
21-
tag: "${NODE_FEATURE_DISCOVERY_VERSION}-minimal"
21+
tag: "v${NODE_FEATURE_DISCOVERY_VERSION}-minimal"
2222
includeCRDs: true
2323
skipTests: true
2424
namespace: node-feature-discovery

‎hack/addons/mindthegap-helm-registry/repos.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2023 D2iQ, Inc. All rights reserved.
1+
# Copyright 2024 Nutanix. All rights reserved.
22
# SPDX-License-Identifier: Apache-2.0
33

44
#=================================================================
@@ -25,7 +25,7 @@ repositories:
2525
repoURL: https://kubernetes-sigs.github.io/node-feature-discovery/charts
2626
charts:
2727
node-feature-discovery:
28-
- v0.15.2
28+
- 0.15.2
2929
nutanix-cloud-provider:
3030
repoURL: https://nutanix.github.io/helm/
3131
charts:
@@ -40,7 +40,7 @@ repositories:
4040
repoURL: https://nutanix.github.io/helm-releases/
4141
charts:
4242
nutanix-csi-storage:
43-
- v3.0.0-beta.1912
43+
- 3.0.0-beta.1912
4444
tigera-operator:
4545
repoURL: https://docs.tigera.io/calico/charts
4646
charts:

‎hack/tools/mindthegap-helm-reg/main.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
// Copyright 2023 D2iQ, Inc. All rights reserved.
1+
// Copyright 2024 Nutanix. All rights reserved.
22
// SPDX-License-Identifier: Apache-2.0
3-
43
package main
54

65
import (

‎make/addons.mk

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ export NODE_FEATURE_DISCOVERY_VERSION := 0.15.2
77
export CLUSTER_AUTOSCALER_VERSION := 9.37.0
88
export AWS_CSI_SNAPSHOT_CONTROLLER_VERSION := v6.3.3
99
export AWS_EBS_CSI_CHART_VERSION := v2.28.1
10-
export NUTANIX_STORAGE_CSI_CHART_VERSION := v3.0.0-beta.1912
11-
export NUTANIX_SNAPSHOT_CSI_CHART_VERSION := v6.3.2
10+
export NUTANIX_STORAGE_CSI_CHART_VERSION := 3.0.0-beta.1912
11+
export NUTANIX_SNAPSHOT_CSI_CHART_VERSION := 6.3.2
1212
export LOCAL_PATH_CSI_CHART_VERSION := v0.0.29
1313
# a map of AWS CCM versions
1414
export AWS_CCM_VERSION_127 := v1.27.1
@@ -62,8 +62,8 @@ update-addon.aws-ccm.%: ; $(info $(M) updating aws ccm $* manifests)
6262
update-addon.kube-vip: ; $(info $(M) updating kube-vip manifests)
6363
./hack/addons/update-kube-vip-manifests.sh
6464

65-
.PHONY: generate-helm-configmap ## this file is now used by generate-mindthegap-repofile
66-
generate-helm-configmap: ; $(info $(M) genrating helm configmap)
65+
.PHONY: generate-helm-configmap
66+
generate-helm-configmap: ; $(info $(M) genrating helm configmap) ## this file is now used by generate-mindthegap-repofile
6767
go run hack/tools/helm-cm/main.go -kustomize-directory="./hack/addons/kustomize" -output-file="./charts/cluster-api-runtime-extensions-nutanix/templates/helm-config.yaml"
6868
./hack/addons/add-warning-helm-configmap.sh
6969

@@ -76,6 +76,6 @@ configure-csi-providers: ; $(info $(M) configuring supported csi providers)
7676
generate-mindthegap-repofile: generate-helm-configmap ; $(info $(M) generating helm repofile for mindthgap)
7777
./hack/addons/generate-mindthegap-repofile.sh
7878

79-
.PHONY: replace-with-mindthegap ## this is used by gorealeaser to set the helm value to this.
80-
replace-with-mindthegap: generate-mindthegap-repofile
81-
sed -i 's/RepositoryURL:.*/RepositoryURL: oci:\/\/mindthegap.{{ .Release.Namespace }}.svc/g' "./charts/cluster-api-runtime-extensions-nutanix/templates/helm-config.yaml"
79+
.PHONY: replace-with-mindthegap
80+
replace-with-mindthegap: generate-mindthegap-repofile ## this is used by gorealeaser to set the helm value to this.
81+
sed -i 's/RepositoryURL:.*/RepositoryURL: oci:\/\/mindthegap.{{ .Release.Namespace }}.svc\/charts/g' "./charts/cluster-api-runtime-extensions-nutanix/templates/helm-config.yaml"

‎make/dev.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ ifndef SKIP_BUILD
2727
endif
2828
kind load docker-image --name $(KIND_CLUSTER_NAME) \
2929
ko.local/cluster-api-runtime-extensions-nutanix:$$(gojq -r .version dist/metadata.json)
30-
kubectl set image deployment cluster-api-runtime-extensions-nutanix webhook=ko.local/cluster-api-runtime-extensions-nutanix:$$(gojq -r .version dist/metadata.json)
30+
kubectl set image deployment -n caren-system cluster-api-runtime-extensions-nutanix webhook=ko.local/cluster-api-runtime-extensions-nutanix:$$(gojq -r .version dist/metadata.json)
3131
kubectl rollout restart deployment cluster-api-runtime-extensions-nutanix
3232
kubectl rollout status deployment cluster-api-runtime-extensions-nutanix
3333

‎pkg/handlers/generic/lifecycle/nfd/strategy_helmaddon.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func (s helmAddonStrategy) apply(
6868

6969
values += fmt.Sprintf(`
7070
image:
71-
tag: %s-minimal
71+
tag: v%s-minimal
7272
`, s.helmChart.Version)
7373

7474
hcp := &caaphv1.HelmChartProxy{

0 commit comments

Comments
 (0)