Skip to content

Commit 11bff42

Browse files
authored
fix: check HelmReleaseReadyCondition when status is up-to-date (#989)
**What problem does this PR solve?**: Only checking for HelmReleaseReadyCondition may not be enough, especially during cluster upgrades where the values in the HCP have changed. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
1 parent 8c40639 commit 11bff42

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/handlers/generic/lifecycle/addons/helmaddon.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,9 @@ func waitToBeReady(
228228
Reader: client,
229229
Target: hcp.DeepCopy(),
230230
Check: func(_ context.Context, obj *caaphv1.HelmChartProxy) (bool, error) {
231+
if obj.ObjectMeta.Generation != obj.Status.ObservedGeneration {
232+
return false, nil
233+
}
231234
return conditions.IsTrue(obj, caaphv1.HelmReleaseProxiesReadyCondition), nil
232235
},
233236
Interval: 5 * time.Second,

0 commit comments

Comments
 (0)